Adding logpath to data plugins collector - #286
Conversation
graepaul
left a comment
There was a problem hiding this comment.
Added comments on files to summarize changes.
There was a problem hiding this comment.
Just docstring updates
There was a problem hiding this comment.
Just docstring updates
There was a problem hiding this comment.
Just docstring updates
There was a problem hiding this comment.
Just docstring updates
There was a problem hiding this comment.
Just docstring updates + annotation updates
There was a problem hiding this comment.
just docstring updates.
There was a problem hiding this comment.
docstring / annotation updates only
There was a problem hiding this comment.
docstring / annotation updates only
There was a problem hiding this comment.
docstring updates only
There was a problem hiding this comment.
docstring updates only
…h_not_passed_to_collectors
Summary
This PR is mainly to fix nodescraper/interfaces/dataplugin.py so that when a collector class is instantiated we create its folder and give it the log_path.
Log Path Collector
Now we create a collectors path by creating the plugin's and collector's folder.
This is then passed into the collector class
Docstring updates
I have updated various docstrings that were missing / out of date.
Test plan
Added new test
Checklist