Repository navigation
fix(skill): harden AgentHub packages and ROS Agent preview boundaries - #413
Merged
Merged
Conversation
guima-why
changed the title
guima-why
changed the title
guima-why
marked this pull request as ready for review
November 1, 2026 11:12
Collaborator
Author
iac-code E2E 报告提交： 安全分析：按作者白名单免检；改动影响分析、用例选择和 E2E 验收照常执行。 链路阶段进展时间为 UTC+8；预计完成时间为估算，运行中计数尚未作为通过证据。
最近网络尝试（仅操作枚举和错误类别，不含请求地址或响应内容）：
full 逐例结果（77 条）
live 逐例结果（136 条）
说明：每个失败用例最多重跑一次；任一次资源清理失败或未验证均不能判通过。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentHub packages could omit their version manifest and derive the User-Agent from a hard-coded version. Generate and validate the manifest for both AgentHub products before outbound requests, and package only each profile's explicit files. ROS Agent deployment-confirmation previews now retain bounded, redacted fields from direct, pipeline, and pipelineBatch envelopes. Deployment decisions remain display-only:
continuerejects them andrespondremains limited to permission prompts.The iac-code Runtime installer still requires external permission scoped to the pinned host, Runtime tag, manifest digest, approver/reference, and a future UTC expiry. Validate it before downloads, redirects, and executable self-checks; retain installer CWD restrictions and private-state path checks. Do not replay an initial A2A request with an unknown outcome before a task ID is known; preserve recovery for existing tasks. ROS Agent artifact reads enforce their own bounded path/URL rules; its code-transport dependencies are pinned with hashes and installed from the explicit wheel-only mirror policy.
The Skill description discloses the first-use 65–81 MB native Runtime download and the installer authorization requirement. AgentHub documentation distinguishes encrypted evaluation inputs in the source repository from the four-file iac-code Skill ZIP: those inputs carry the recorded evaluation scope and deadline, grant no release-wide exception, and must not be copied outside that scope, decrypted, printed, or extended. Packaging reopens the ZIP to verify exact entries and bytes and exclude harness settings. The ROS Agent AgentHub ZIP has its own nine-file whitelist.
Keep Runtime v0.17.0 and its immutable artifacts unchanged. The provenance record identifies its published source tag, controlled-publisher revision, manifest, three archive digests/sizes, native build tooling, and idempotency ownership. It explicitly distinguishes integrity checks from a signature, reproducible build, independent binary audit, or installer approval. No independent binary audit or native build/verification receipts are provided or will be supplied for this Skill release. No receipt, security approval, or platform waiver is invented.
Integration and semantic checks:
5ef5add1,2051b3fb, and2b322d33with their original commit references.Validation: 775 offline tests passed (
tests/skill_bridgeplus the repository-wide UTF-8 check). Ruff, ty, profile/default synchronization, diff checks, Python 3.8 AST parsing, and Python 3.8/3.9 standard-library bridge smoke checks passed. CI on head9e217b82passed: Test 14/14 jobs (Lint, seven Python 3.8–3.14 Skill bridges, five Linux Python 3.10–3.14 full suites, and Windows Python 3.10); Desktop 4/4 jobs (scope audit and Linux/macOS/Windows platforms). CLA also passed.The iac-code bridge executable and its existing generated documentation/RAM reference retain their pre-integration bytes. Existing iac-code scenario identities and files are unchanged. No native Runtime assets were rebuilt or replaced.