fix(import): apply clear/replace existing on the final batch

[Hami0095]

Summary

Fixes #191.

algolia rules import --clear-existing-rules (and algolia synonyms import --replace-existing-synonyms) silently does nothing for any input file under 1000 entries — which is nearly all of them.

Both commands import in batches of 1000. In pkg/cmd/rules/import/import.go, the clear flag is only attached to the SaveRules request in the batch-full path:

if count == batchSize {
    res, err := client.SaveRules(
        client.NewApiSaveRulesRequest(opts.Index, rules).
            WithClearExistingRules(clearExistingRules).
            WithForwardToReplicas(opts.ForwardToReplicas),
    )
    ...

The final partial batch calls SaveRules with no clear flag at all:

if count > 0 {
    res, err := client.SaveRules(
        client.NewApiSaveRulesRequest(opts.Index, rules).
            WithForwardToReplicas(opts.ForwardToReplicas), // no WithClearExistingRules
    )

A file under 1000 rules never fills the buffer, so this final call is the only SaveRules request sent — and it drops the flag. The existing ClearRules fallback is guarded by totalCount == 0, so it only helps for an empty input file, not a small non-empty one.

pkg/cmd/synonyms/import/import.go has the identical defect: WithReplaceExistingSynonyms is attached in the batch-full path but not the tail block.

Fix

Pass the flag to the final batch's request too, conditioned on whether it hasn't already been consumed by an earlier full batch — this keeps the wire format unchanged for multi-batch imports (a later request still omits the parameter rather than sending clearExistingRules=false).

Test plan

• Added a sub-batch-size case to both pkg/cmd/rules/import/import_test.go and pkg/cmd/synonyms/import/import_test.go asserting the outgoing request carries the flag when set, and omits it when not
• Confirmed the new "small batch ... clear existing" cases fail against unpatched main and pass with the fix
• go build ./..., go vet ./... clean
• go test ./... — no new regressions (pre-existing Windows-path test failures in a handful of import/operations/update packages are unchanged by this diff, and unrelated to it)

🤖 Generated with Claude Code

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 10 duplication

Metric	Results
Duplication	10

View in Codacy

_{TIP This summary will be updated as you push new changes.}