Skip to content

fix(layout): leave a section holding an object in a switch unsupported in the page estimate - #502

Merged
airmang merged 1 commit into
mainfrom
fix/page-estimate-objects-in-a-switch
Oct 17, 2026
Merged

airmang merged 1 commit into
mainfrom
fix/page-estimate-objects-in-a-switch

Conversation

@airmang

@airmang airmang commented Oct 17, 2026

Copy link
Copy Markdown
Owner

Summary

  • A chart is saved in a run's hp:switch, with the OLE object standing for it in hp:default. Hancom Office lays such an object out like any other: wrapped square, it narrows the lines beside it.
  • The page estimate looked for objects among a run's own children only. So it laid those lines out as if the object were not there.
  • It now leaves such a section unsupported (an object in a switch (hp:switch)) rather than estimating it wrongly.

Test plan

  • A paragraph holding a square-wrapped chart in a switch is reported unsupported; without the switch the document is estimated. The test fails before the change.
  • Lint, format, type checks and the other repository gates
  • Layout tests

🤖 Generated with Claude Code

@airmang airmang left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed exact head 68bb443 and surrounding section-support/object discovery code. Reporting sections containing objects in a run-level hp:switch as unsupported is a conservative response to currently unmeasured wrapping; chart/default-OLE coverage and removal comparison exercise the boundary. No code defect found. Locally, 10 related switch/unsupported tests passed. All 13 exact-head checks pass; workflow SHA verified and CI test/lint/type/hygiene logs inspected (6,867 passed, 18 skipped, 1 xfailed).

Merge is held: after #499 and #501 merged, scratch integration against current main 97c2bef reproduces a CHANGELOG.md content conflict. Preserve both PR changelog entries when resolving against latest main, then revalidate the updated head. No conflict resolution was pushed and no integration-test pass is claimed for the conflicted tree.

…in the page estimate

A chart is saved in a run's hp:switch, the OLE object standing for it in hp:default, and Hancom Office lays it
out like any other object: wrapped square, it narrows the lines beside it. The page estimate looked for
objects among a run's own children only and laid those lines out as if it were not there; such a section is
now unsupported.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@airmang
airmang force-pushed the fix/page-estimate-objects-in-a-switch branch from 68bb443 to 40cbc96 Compare October 17, 2026 11:15
@airmang
airmang merged commit aaa3a05 into main Oct 17, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant