Repository navigation
docs: say format details were inferred from Hancom-saved documents - #469
Merged
Merged
Conversation
Comments, docstrings, test notes and reports described how python-hwpx learned parts of the file format (version.xml, master pages, fields, drop caps, dutmal, table labels, the native TOC contract and so on) as "reverse-engineered". What was done is reading documents Hancom saved and inferring the structure from them; no Hancom program was analysed. The wording now says so: "inferred" and "format inference". No behaviour changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
airmang
commented
Oct 15, 2026
airmang
left a comment
Owner
Author
There was a problem hiding this comment.
f212ecc 검토 완료. 25개 파일의 diff를 확인했고, 모든 변경이 reverse-engineered → inferred / reverse engineering → format inference 표현 교체에 한정됨을 원문 대조로 검증했습니다. JSON의 수치·구조·소유권 판정과 실행 로직은 유지됩니다. Python/JSON 파싱과 public hygiene 검사가 통과했고, 변경 관련 기존 테스트 72개도 별도 Python 3.12 체크아웃에서 통과했습니다. 최신 head의 GitHub 검사 13개가 모두 성공했으며, 실제 Python 3.12 CI 로그에서 6,742 passed / 18 skipped / 1 xfailed, coverage 89.96%, mypy와 Pyright 성공을 확인했습니다. 병합을 막는 결함이나 미해결 리뷰 스레드가 없습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요약
주석·독스트링·시험 설명·보고서에서, python-hwpx가 파일 형식 일부(version.xml, 바탕쪽, 필드, 문단 첫 글자 장식, 덧말, 표 라벨, 차례 필드 등)를 알아낸 방법을 "reverse-engineered"라고 적은 곳이 25개 파일 43곳 있었다. 실제로 한 일은 한/글이 저장한 문서를 읽고 구조를 추론한 것이고, 한컴 프로그램을 분석한 것이 아니다. 이를 정확히 나타내도록 표현을 바꾼다.
동작 변화는 없다.
시험
🤖 Generated with Claude Code