Repository navigation
lockfree map, used to make Cache.Count domain safe - #72
Merged
Merged
Conversation
c-cube
added this pull request to stack #73
October 1, 2026 15:18
c-cube
force-pushed
the
sc/fast-lockfree-map
branch
from
October 1, 2026 19:45
6c704f8 to
7dc1b13
Compare
c-cube
marked this pull request as ready for review
October 2, 2026 01:23
| "high bits", { H.equal = Int.equal; hash = (fun k -> Hashtbl.hash k lsl 32) }; | ||
| ] | ||
|
|
||
| type op = Get_or_create of int * int | Find of int | Mem of int | Clear |
Contributor
There was a problem hiding this comment.
not so much a review as a question:
would this kind of test be better expressed as a state-machine test? (with e.g. qcheck-stm)
it seems you are re-encoding part of the logic. i think it's fine bc there isn't too much logic to encode and not too much boilerplate to go along with it. it's sometimes better to go for the test framework you are familiar with. i was just curious if there's another reason for the choice.
Contributor
Author
There was a problem hiding this comment.
this is claude, tbh, but in containers I tend to do the same (list of ops, easy to shrink, grug style)
added 2 commits
October 6, 2026 12:12
to be used in Cache.
c-cube
force-pushed
the
sc/fast-lockfree-map
branch
2 times, most recently
from
October 6, 2026 16:13
d1afd90 to
491656b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.