Repository navigation
domain safety for log, rate limiter, parts of cache - #71
Merged
Merged
Conversation
added 4 commits
September 30, 2026 13:49
not the config part, but logging.
c-cube
added this pull request to stack #73
October 1, 2026 15:18
c-cube
marked this pull request as ready for review
October 1, 2026 19:46
Comment on lines
+32
to
+41
| type bucket = { | ||
| tokens: float; | ||
| last_update: float; | ||
| } | ||
|
|
||
| type t = | ||
| | Unlimited | ||
| | RL of { | ||
| mutable tokens: float; | ||
| mutable count_silenced: int; | ||
| mutable last_update: float; | ||
| bucket: bucket Atomic.t; (** current state. avoid mutex for reentrancy *) | ||
| count_silenced: int Atomic.t; |
Contributor
There was a problem hiding this comment.
ping @davesnx this is potentially a good motivating example for nested record types:
- need to introduce a new type just to group the atomicity together
- new type isn't necessarily semantically meaningful, just "need to update together" is why it's introduced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.