Repository navigation
fix: say optional checks are running, not failing, while they run - #163
Merged
Merged
Conversation
GitHub's UNSTABLE merge state covers any optional check that hasn't passed, a running one included, so a PR with nothing failed read as "optional checks failing". It now says failing only when a check failed, and "optional checks running" while the rollup is pending. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QUnP8jVL2NG9cWmohJTyun
brtkwr
enabled auto-merge
October 28, 2026 19:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A PR whose only unfinished check was an optional one still running (two-inc/aries#469,
run_tests (pd_gb_new_v2) / testsin progress, everything else green) showed "ready to merge · optional checks failing". GitHub's UNSTABLE state means any optional check not passed yet, running included.Now: "optional checks failing: " only when a check failed, "optional checks running" while the rollup is pending, else plain "ready to merge".
🤖 Generated with Claude Code
https://claude.ai/code/session_01QUnP8jVL2NG9cWmohJTyun