Skip to content

Fix HTTPException body mapping when extra-info key is body #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 3 commits into from
Closed

Fix HTTPException body mapping when extra-info key is body #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ad0c81
Handle both HTTP body extra-info keys
Copilot Sep 9, 2026
1691171
Relax HTTPException body assertion
Copilot Sep 9, 2026
c309cb3
Require non-empty HTTPException body in test
Copilot Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/common/exceptions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ void PyThrowException(ErrorData &error, PyObject *http_exception) {
for (auto &entry : error.ExtraInfo()) {
if (entry.first == "status_code") {
e.attr("status_code") = std::stoi(entry.second);
} else if (entry.first == "response_body") {
} else if (entry.first == "response_body" || entry.first == "body") {
e.attr("body") = entry.second;
} else if (entry.first == "reason") {
e.attr("reason") = entry.second;
Expand Down
3 changes: 2 additions & 1 deletion tests/extensions/test_httpfs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ def test_http_exception(self, require):

value = exc.value
assert value.status_code != 200
assert value.body == ""
assert isinstance(value.body, str)
Comment thread
afeld marked this conversation as resolved.
assert value.body != ""
assert "Content-Length" in value.headers

def test_fsspec_priority(self, require):
Expand Down