Conversation
…in a multi-master configuration
…erving legacy behavior.
…added stopTransmissionWIRE to allow sync closeout, handle errors and continue processing the transaction queue
…g ISR called APIs
…or pin assignment validation
- Fix misleading indentation in retry logic (lines 847, 857) - Remove ambiguous overload for Wire.begin() with integer literals (uint16_t version now requires explicit enableGeneralCall parameter) - Remove unused variable in SPI.cpp - Remove redundant unsigned < 0 check in setPending()
- Add __attribute__((weak)) to all SPI interrupt handlers (SERCOM4, SPI1, etc) This allows variants to override them when SERCOM is used for other peripherals (e.g., MKR variants use SERCOM4 for Serial2/UART) - Explicitly cast slave addresses to uint8_t in Wire examples to avoid any potential overload resolution issues on different compiler versions
This was referenced Sep 27, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SPI.end()abort active transfers and clear queued source pointers before callers release their buffers. Preserve the incoming interrupt-mask state.This replaces #385. The original PR remains available for its discussion and history, but its
sercom-async-dmahead diverged before the SAME5x integration work. This replacement allows CI and review to run against the branch containing the SAME5x integration without rewriting the old public branch.Validation
Current SPI fix validation
GitHub CI: all 12 jobs pass on the updated PR head.
Full local 12-job CI matrix: 287 successful example compiles, zero failures, and 433 existing skips at
76492a7993f63a2c4687fcdeb5a57853a2272598.Native SPI buffer-lifetime reproduction: all eight cases pass.
Earlier validation
0b814e16.Hardware validation
Dependencies
057f6734f589680072de3a467b3b4051e57f3a9e25e92a0811b364a068989c43788727c18803fc77SPI buffer lifetime regression
SPI.end()previously left the DMA engine and queued transaction pointers active after returning. The change toSERCOM::resetSPI()cancels transfer activity and clears those references before releasing caller-owned memory.The native reproduction failed against the previous implementation and passes against this commit. A SAME54 J-Link probe independently reproduced the stale DMA ownership and verified cancellation after the fix. This also supports NeoPixel SERCOM output, which retains each encoded source buffer until SPI completion.