Repository navigation
Add full and minimal templates, isolated E2E tests, and demo/docs apps - #31
Open
joshuasilva414 wants to merge 5 commits into
Open
joshuasilva414 wants to merge 5 commits into
joshuasilva414 wants to merge 5 commits into
Conversation
- Templates don't come with migrations - Execution time ORM optimizations
|
Important Review skippedToo many files! This PR contains 432 files, which is 332 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 300 files.
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #28. Targets
remove-next-packageso this diff contains only the follow-up changes ontemplates-and-testing. Merge #28 first, then retarget this PR todev.Changes
imageproperty across Core and UI. Include the demo's database migration for this rename.pnpm/action-setup. Remove the runner's Corepack dependency and update the E2E setup commands. This fixes the CI setup failure caused by Corepack's missing pnpm entrypoint.Compatibility
The profile API changes from
profilePhotoUrltoimage. Existing applications need to generate and review the corresponding database migration. Templates remain workspace examples; standalone package distribution andhackkit initare deferred.Validation
corepack pnpm test: all 70 package tests passed.corepack pnpm exec turbo run typecheck --filter='./packages/*': passed.git diff --check origin/remove-next-package...HEAD: passed.pnpm test:e2e:dbpassed locally: 9 tests passed and 3 external database tests skipped. The run also passed dependency builds, plugin sync, template/E2E typechecks, and browser bundle checks.The HTTP/browser E2E suites, external database matrix, app production builds, and deployment checks were not rerun locally for the pnpm invocation change. They are configured in the new CI workflows.