Repository navigation
Handle undefined and combined flag values in AbpEnumLocalizer - #26344
Open
johnkaram02 wants to merge 2 commits into
Open
johnkaram02 wants to merge 2 commits into
johnkaram02 wants to merge 2 commits into
Conversation
|
|
AbpEnumLocalizer used Type.GetEnumName as the member name. GetEnumName returns null for a value that has no named member, such as (BookType)42 or a combination of [Flags] members. The null key then reached the string localizer and GetString threw an ArgumentNullException. Fall back to the enum's ToString() result, such as "42" or "Read, Write", when the value has no named member.
maliming
force-pushed
the
fix/enum-localizer-undefined-value
branch
from
October 28, 2026 05:40
377e2b5 to
ce06e78
Compare
Member
|
Thanks for the PR. Bug fixes go to the release branch first and are merged into Please complete the CLA check, then we can merge it. |
maliming
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AbpEnumLocalizerand the obsoleteEnumHelperthrewArgumentNullExceptionfor values without a named member, such as(BookType)42or a combined[Flags]value. They now fall back to the enum'sToString()result ("42","Read, Write"). Named members behave as before.