Pass text values through t, and render app 483's launchpad flag through b - #71
Merged
Merged
Conversation
check_launchpad_active is an abap_bool, and written through v it reached the view as visible="X" - a value UI5 refuses for a boolean property, so both buttons showed regardless of where the app ran. b renders true/false. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SzFGoLSjycYRD1zvvxqRVJ
The framework's view builder takes text through a( t = ) now: the value is escaped as a literal, so a brace or backslash in it is shown instead of parsed as a binding. Every attribute value whose origin is data - a template that interpolates, a record field, an event argument, a text variable, a name-and-literal chain - moves onto t; constants, bindings, events and expressions stay on v, where the builder writes them as they are. Needs abap2UI5 with the t parameter of z2ui5_cl_ui5_view_builder=>a( ). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SzFGoLSjycYRD1zvvxqRVJ
This was referenced Sep 12, 2026
oblomov-dev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Two things, two commits:
Text values through
t. Every attribute value whose origin is data moves froma( v = … )ontoa( t = … ): 15 attributes in the overview app (tile texts, hints, icons, CSS classes, the tooltiphref) and app 010 (|Edit Travel { s_draft-travel_id } (Draft)|).tis the new third value form ofz2ui5_cl_ui5_view_builder=>a( )(Let a( ) take text through t so data in a view attribute is escaped by the builder abap2UI5#2732): the builder appliesescape_literal( )to it, so a brace or backslash in the value is shown instead of parsed by UI5 as a binding. Not a rename with identical behaviour — that is why constants, bindings and events stay onv.A bug in app 483.
visiblewas fedclient->get( )-check_launchpad_active, anabap_bool, throughv— it reached the view asvisible="X", which UI5 refuses for a boolean property, so both launchpad buttons showed wherever the app ran. It goes throughbnow, which renderstrue/false.Why
A data value written through
vis a binding to UI5 when it carries a brace. The linter ruleunescaped-text-in-attribute(abap2UI5/linter#102) reports the remainingvvalues with data — 0 on this branch.Checks
mainresolution keeps CI red on lint until #2732 lands — this PR after that one)npm run check:abap2ui5: 32 files, 0 failingcheck:overview,check:keywords,check:abapdoc,check:samples-md,check:catalogue,check:app-rules,check:prose,check:derived: OK🤖 Generated with Claude Code
https://claude.ai/code/session_01SzFGoLSjycYRD1zvvxqRVJ