Repository navigation
Conversation
The phonon-loss tutorial moves to `components`, with "total", "elastic" and "diffuse" in place of "incoherent", "coherent" and "tds", mentions elastic_diffuse_diffraction_patterns, unbiased and reduction_dtype, and is re-executed against abTEM dev (2b764f5c) so the figures carry the new names. The changelog gains the #484 feature entry and its two bug fixes: block_direct=True and the precision of lazy diffraction patterns. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Checked against
🤖 Written and posted by Claude Code on Paul's behalf |
Following review: the tutorial and the changelog's tutorial entry say "the decomposition into total, elastic and diffuse intensity" instead of "TDS decomposition"; the zero-energy bin vanishes up to floating-point rounding rather than exactly; and the #484 changelog entry names the temperature validation, the order of a tuple of components, and the component check of momentum_resolved_spectrum. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks, all four are done in
Only markdown cells changed, so the notebook was not re-executed. 🤖 Written by Claude Code on Toma's behalf. |
|
Thanks, Paul, for checking every name against dev and for catching the leftover TDS wording and the "exactly zero" claims. I re-ran the phonon-loss tutorial against abTEM 🤖 Written by Claude Code on Toma's behalf. |
Updates the documentation for abTEM#484, which settled the names of the frozen-phonon components and added
elastic_diffuse_diffraction_patterns.Phonon-loss tutorial
docs/user_guide/tutorials/phonon_loss.ipynb:component="all"andcomponent="tds"becomecomponents="all"and the default"diffuse". The prose and equations use total, elastic and diffuse in place of incoherent, coherent and TDS."all"is described in its new order: total, elastic, diffuse.elastic_diffuse_diffraction_patterns, which forms the same decomposition without an energy axis.unbiased=Trueandreduction_dtype="float64".devat2b764f5c, the merge of #484, so the stored figures carry the new component labels. It runs in about 70 s on CPU, with no errors or warnings.Changelog
docs/abtem/changelog.md, under 1.1.0:elastic_diffuse_diffraction_patterns, and the renamedcomponentsofphonon_loss_diffraction_patterns. The phonon-loss functions are not in a release yet, so the rename is listed with the feature rather than as a breaking change.block_direct=TrueinWaves.diffraction_patternsblocked a fixed 1 mrad radius. It now blocks the probe's bright-field disk plus a margin, or the zero-frequency pixel for a plane wave.Not changed
frozen_phonons.ipynb(walkthrough) andcharge_density.ipynbcalldiffraction_patterns(block_direct=True)on plane waves. With #484 that blocks only the zero-frequency pixel, where it used to block 1 mrad. Their code needs no change, but their stored figures predate the change until the notebooks are next re-run.charge_density.ipynbneeds GPAW to re-run.🤖 Generated with Claude Code