Skip to content

feat: add start advarg to playlist commands - #92

Merged
wizzomafizzo merged 1 commit into
mainfrom
feat/playlist-start-advarg
Oct 23, 2026
Merged

wizzomafizzo merged 1 commit into
mainfrom
feat/playlist-start-advarg

Conversation

@wizzomafizzo

@wizzomafizzo wizzomafizzo commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Adds a start advanced argument to the playlist commands. It names the item to open on, counted from 1. Core uses it to override the remembered playlist position, so start=1 always starts from the top.

Ref ZaparooProject/zaparoo-core#1234

Summary by CodeRabbit

  • New Features
    • Added an optional numeric start setting for playlists. It selects the 1-based item position where playback begins.
    • Setting start to 1 begins playback at the top of the playlist instead of resuming from the previous position. Other numeric values let you choose a later playlist item as the starting point.

@coderabbitai

coderabbitai Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 57e3149e-00cf-4582-9cac-582d2181b679
📥 Commits

Reviewing files that changed from the base of the PR and between ca8a06e and 4ae4dfd.

📒 Files selected for processing: 2
  • types.go
  • types_advargs_test.go

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The change adds a start advanced argument to PlaylistArgs. It represents a 1-based playlist item position. The test checks that the field uses the KeyStart argument tag.

Changes: Playlist start argument

Layer / File(s) Summary
Define and verify the start argument
types.go, types_advargs_test.go
Adds the KeyStart key and optional PlaylistArgs.Start field. The value "1" starts at the top rather than resuming the previous position. A test checks the field’s advarg tag.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature

Possibly related issues

  • ZaparooProject/zaparoo-frontend#572: The request concerns booting a chosen game. The new argument selects a playlist item by position, but does not address startup timing or splash screens.
Merge Risk: ⚪ Minimal · up to 4ae4d

The changed argument and tag test show no confirmed merge-blocking issue in the available evidence.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: adding the start advanced argument to playlist commands.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@wizzomafizzo
wizzomafizzo merged commit 88683b2 into main Oct 23, 2026
12 checks passed
@wizzomafizzo
wizzomafizzo deleted the feat/playlist-start-advarg branch October 23, 2026 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant