Repository navigation
Teams calls: add a screen share line when starting without one - #54
Merged
Merged
Conversation
A 1:1 Teams call's initial offer carries only audio and camera lines. When we start screen sharing, add a sendonly share line at the camera's H.264 codec to the renegotiation offer. If the far end answers without taking the share line, stop sharing and report that the call did not take the share.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a 1:1 Teams call begins, its initial offer carries only audio and camera lines. When screen sharing is started later in the call:
sendonlyshare line at the camera's H.264 codec to the renegotiation offer (reoffer).HuddleTrouble::ShareNotTaken).CallEvent::ShareRefusedacross probe and internal call event routing.ShareTaskandShareWiringto keep type complexity and function arguments clean.sdp.rs,media.rs, andcall.rs.