Repository navigation
Track recently used emojis and quick reactions per workspace - #53
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Slack custom emojis are workspace-dependent, but previously
recent_emojiwas stored globally across all workspaces inSettings. As a result, custom emojis used in one workspace could appear in the quick reaction toolbars or recent lists across all workspaces.This PR tracks recently used emojis and quick reactions per workspace:
src/settings.rs):recent_emojiis now aBTreeMap<String, Vec<String>>keyed by workspace ID (team_id). Backwards-compatible deserialization migrates existing global recent lists to the active workspace.src/app/compose.rs): Sending messages, replies, files, and reactions records recently used emojis under their correspondingteam_id.src/app/compose.rs,src/ui/mod.rs,src/ui/message/menu.rs):quick_reactionsresolves emojis for each message's workspace and excludes custom emojis not belonging to that workspace.src/ui/overlays.rs): The "Recently used" group is now scoped and cached per workspace.