Skip to content

fix: resolve CodeQL alerts and add Storybook i18n decorator - #457

Merged
yshls merged 4 commits into
developfrom
fix/codeql-storybook-i18n
Nov 18, 2026
Merged

yshls merged 4 commits into
developfrom
fix/codeql-storybook-i18n

Conversation

@yshls

@yshls yshls commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • CodeQL fix: typeof guard on mock handler dispatch in client.ts to satisfy "unvalidated dynamic method call" alert
  • Storybook fix: Add NextIntlClientProvider decorator in .storybook/preview.tsx so components using useTranslations render correctly in Storybook tests

Test plan

  • CI unit tests pass (TranquilityGauge stories no longer fail)
  • CodeQL alert for client.ts handler dispatch resolved

🤖 Generated with Claude Code

yshls and others added 2 commits November 18, 2026 12:44
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Storybook tests failed because components using useTranslations had no
NextIntlClientProvider wrapping them.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 26 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between f731b48 and 765ebf3.

Files selected for processing: 8

  • .storybook/preview.tsx
  • src/app/[locale]/mypage/page.tabRail.test.ts
  • src/features/map/components/InfoPlaceList.test.tsx
  • src/features/map/components/PlaceDetail.headerActions.test.ts
  • src/features/map/components/feed/LiveNoticeBanner.test.tsx
  • src/lib/api/client.ts
  • src/private/core-ui/map-warmth/WarmthFeed.spacing.test.ts
  • src/private/core-ui/sorimaru/SorimaruEditorialRail.test.tsx
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

Copy link
Copy Markdown

📋 코드 리뷰 체크리스트

  • 테스트 추가/업데이트
  • 문서 업데이트
  • 콘솔 로그/디버거 없음
  • 하드코딩된 값 없음
  • 성능 고려됨
  • 보안 검토됨
  • 에러 처리 추가됨

@github-actions

Copy link
Copy Markdown

✅ PR 검증 통과

  • 제목 형식: ✓
  • 설명: ✓
  • 파일 수정: ✓

@github-actions

Copy link
Copy Markdown

📦 번들 크기 분석 요약:

번들 크기 분석 결과

Next.js 빌드 출력 크기

221M .next

가장 큰 파일 상위 20개

15M .next/cache/turbopack/v16.4.3-29bbeab0/00000022.sst
15M .next/cache/turbopack/v16.4.3-29bbeab0/00000008.sst
14M .next/cache/turbopack/v16.4.3-29bbeab0/00000004.sst
14M .next/cache/turbopack/v16.4.3-29bbeab0/00000003.sst
13M .next/cache/turbopack/v16.4.3-29bbeab0/00000016.sst
13M .next/cache/turbopack/v16.4.3-29bbeab0/00000014.sst
13M .next/cache/turbopack/v16.4.3-29bbeab0/00000007.sst
12M .next/cache/turbopack/v16.4.3-29bbeab0/00000019.sst
12M .next/cache/turbopack/v16.4.3-29bbeab0/00000018.sst
12M .next/cache/turbopack/v16.4.3-29bbeab0/00000015.sst
12M .next/cache/turbopack/v16.4.3-29bbeab0/00000009.sst
11M .next/cache/turbopack/v16.4.3-29bbeab0/00000006.sst
6.1M .next/static/chunks/1vu6vf_pg32i7.js
6.1M .next/server/chunks/ssr/src_app_dev_icons_page_tsx_0bmgqvoiobm8p._.js
4.8M .next/cache/turbopack/v16.4.3-29bbeab0/00000010.sst
4.3M .next/cache/turbopack/v16.4.3-29bbeab0/00000021.sst
3.1M .next/cache/turbopack/v16.4.3-29bbeab0/00000005.sst
3.1M .next/cache/turbopack/v16.4.3-29bbeab0/00000002.sst
3.1M .next/cache/turbopack/v16.4.3-29bbeab0/00000001.sst
2.4M .next/cache/turbopack/v16.4.3-29bbeab0/00000012.sst

@github-actions

Copy link
Copy Markdown

⚡ Lighthouse 성능 감사가 완료되었습니다. 아티팩트에서 상세 리포트를 확인하세요.

@github-actions

Copy link
Copy Markdown

📦 번들 크기 분석 요약:

번들 크기 분석 결과

Next.js 빌드 출력 크기

221M .next

가장 큰 파일 상위 20개

15M .next/cache/turbopack/v16.4.3-29bbeab0/00000003.sst
14M .next/cache/turbopack/v16.4.3-29bbeab0/00000009.sst
14M .next/cache/turbopack/v16.4.3-29bbeab0/00000004.sst
13M .next/cache/turbopack/v16.4.3-29bbeab0/00000020.sst
13M .next/cache/turbopack/v16.4.3-29bbeab0/00000005.sst
12M .next/cache/turbopack/v16.4.3-29bbeab0/00000019.sst
12M .next/cache/turbopack/v16.4.3-29bbeab0/00000016.sst
12M .next/cache/turbopack/v16.4.3-29bbeab0/00000014.sst
12M .next/cache/turbopack/v16.4.3-29bbeab0/00000011.sst
11M .next/cache/turbopack/v16.4.3-29bbeab0/00000010.sst
11M .next/cache/turbopack/v16.4.3-29bbeab0/00000007.sst
9.8M .next/cache/turbopack/v16.4.3-29bbeab0/00000006.sst
6.1M .next/static/chunks/1vu6vf_pg32i7.js
6.1M .next/server/chunks/ssr/src_app_dev_icons_page_tsx_0bmgqvoiobm8p._.js
4.0M .next/cache/turbopack/v16.4.3-29bbeab0/00000024.sst
4.0M .next/cache/turbopack/v16.4.3-29bbeab0/00000012.sst
3.1M .next/cache/turbopack/v16.4.3-29bbeab0/00000008.sst
3.1M .next/cache/turbopack/v16.4.3-29bbeab0/00000002.sst
3.1M .next/cache/turbopack/v16.4.3-29bbeab0/00000001.sst
2.9M .next/cache/turbopack/v16.4.3-29bbeab0/00000021.sst

@github-actions

Copy link
Copy Markdown

✅ 코드 품질 검사가 완료되었습니다. 위 출력 결과에서 이슈를 확인하세요.

@github-actions

Copy link
Copy Markdown

♿ 접근성 감사가 완료되었습니다. 아티팩트의 a11y-report를 확인하세요.

@github-actions

Copy link
Copy Markdown

📊 테스트 커버리지 리포트

테스트 커버리지 요약

사용 가능한 커버리지 데이터가 없습니다.

@github-actions

Copy link
Copy Markdown

🔍 CodeQL 보안 분석이 완료되었습니다. 세부 검출 결과는 리포지토리의 Security 탭을 확인하세요.

@github-actions

Copy link
Copy Markdown

✅ E2E 테스트가 완료되었습니다. 아티팩트에서 Playwright 리포트를 확인하세요.

- InfoPlaceList: mock next-intl for CulturalDiscoveryCollection
- SorimaruEditorialRail: mock next-intl for SorimaruRequestErrorState
- LiveNoticeBanner: remove premature i18n mock, test actual Korean text

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

✅ PR 검증 통과

  • 제목 형식: ✓
  • 설명: ✓
  • 파일 수정: ✓

@github-actions

Copy link
Copy Markdown

📦 번들 크기 분석 요약:

번들 크기 분석 결과

Next.js 빌드 출력 크기

221M .next

가장 큰 파일 상위 20개

15M .next/cache/turbopack/v16.4.3-29bbeab0/00000009.sst
15M .next/cache/turbopack/v16.4.3-29bbeab0/00000003.sst
14M .next/cache/turbopack/v16.4.3-29bbeab0/00000010.sst
13M .next/cache/turbopack/v16.4.3-29bbeab0/00000015.sst
13M .next/cache/turbopack/v16.4.3-29bbeab0/00000014.sst
13M .next/cache/turbopack/v16.4.3-29bbeab0/00000011.sst
13M .next/cache/turbopack/v16.4.3-29bbeab0/00000004.sst
12M .next/cache/turbopack/v16.4.3-29bbeab0/00000020.sst
12M .next/cache/turbopack/v16.4.3-29bbeab0/00000018.sst
12M .next/cache/turbopack/v16.4.3-29bbeab0/00000008.sst
9.9M .next/cache/turbopack/v16.4.3-29bbeab0/00000005.sst
8.6M .next/cache/turbopack/v16.4.3-29bbeab0/00000006.sst
6.1M .next/static/chunks/1vu6vf_pg32i7.js
6.1M .next/server/chunks/ssr/src_app_dev_icons_page_tsx_0bmgqvoiobm8p._.js
5.2M .next/cache/turbopack/v16.4.3-29bbeab0/00000012.sst
4.9M .next/cache/turbopack/v16.4.3-29bbeab0/00000024.sst
4.9M .next/cache/turbopack/v16.4.3-29bbeab0/00000019.sst
4.4M .next/cache/turbopack/v16.4.3-29bbeab0/00000023.sst
3.1M .next/cache/turbopack/v16.4.3-29bbeab0/00000007.sst
3.1M .next/cache/turbopack/v16.4.3-29bbeab0/00000002.sst

@github-actions

Copy link
Copy Markdown

📦 번들 크기 분석 요약:

번들 크기 분석 결과

Next.js 빌드 출력 크기

221M .next

가장 큰 파일 상위 20개

14M .next/cache/turbopack/v16.4.3-29bbeab0/00000010.sst
13M .next/cache/turbopack/v16.4.3-29bbeab0/00000020.sst
13M .next/cache/turbopack/v16.4.3-29bbeab0/00000018.sst
13M .next/cache/turbopack/v16.4.3-29bbeab0/00000008.sst
13M .next/cache/turbopack/v16.4.3-29bbeab0/00000007.sst
13M .next/cache/turbopack/v16.4.3-29bbeab0/00000003.sst
12M .next/cache/turbopack/v16.4.3-29bbeab0/00000017.sst
12M .next/cache/turbopack/v16.4.3-29bbeab0/00000015.sst
12M .next/cache/turbopack/v16.4.3-29bbeab0/00000011.sst
12M .next/cache/turbopack/v16.4.3-29bbeab0/00000005.sst
11M .next/cache/turbopack/v16.4.3-29bbeab0/00000006.sst
11M .next/cache/turbopack/v16.4.3-29bbeab0/00000004.sst
6.1M .next/static/chunks/1vu6vf_pg32i7.js
6.1M .next/server/chunks/ssr/src_app_dev_icons_page_tsx_0bmgqvoiobm8p._.js
3.8M .next/cache/turbopack/v16.4.3-29bbeab0/00000021.sst
3.4M .next/cache/turbopack/v16.4.3-29bbeab0/00000024.sst
3.2M .next/cache/turbopack/v16.4.3-29bbeab0/00000012.sst
3.1M .next/cache/turbopack/v16.4.3-29bbeab0/00000019.sst
3.1M .next/cache/turbopack/v16.4.3-29bbeab0/00000016.sst
3.1M .next/cache/turbopack/v16.4.3-29bbeab0/00000009.sst

@github-actions

Copy link
Copy Markdown

✅ 코드 품질 검사가 완료되었습니다. 위 출력 결과에서 이슈를 확인하세요.

@github-actions

Copy link
Copy Markdown

♿ 접근성 감사가 완료되었습니다. 아티팩트의 a11y-report를 확인하세요.

@github-actions

Copy link
Copy Markdown

📊 테스트 커버리지 리포트

테스트 커버리지 요약

사용 가능한 커버리지 데이터가 없습니다.

@github-actions

Copy link
Copy Markdown

⚡ Lighthouse 성능 감사가 완료되었습니다. 아티팩트에서 상세 리포트를 확인하세요.

@github-actions

Copy link
Copy Markdown

🔍 CodeQL 보안 분석이 완료되었습니다. 세부 검출 결과는 리포지토리의 Security 탭을 확인하세요.

- tabRail: test scrollable container instead of removed touch-action
- headerActions: bookmark toggle is now in header group (not bottom bar)
- WarmthFeed: match actual padding values (40px gutter, 24px pagination)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

✅ PR 검증 통과

  • 제목 형식: ✓
  • 설명: ✓
  • 파일 수정: ✓

@github-actions

Copy link
Copy Markdown

📦 번들 크기 분석 요약:

번들 크기 분석 결과

Next.js 빌드 출력 크기

221M .next

가장 큰 파일 상위 20개

15M .next/cache/turbopack/v16.4.3-29bbeab0/00000010.sst
13M .next/cache/turbopack/v16.4.3-29bbeab0/00000021.sst
13M .next/cache/turbopack/v16.4.3-29bbeab0/00000013.sst
13M .next/cache/turbopack/v16.4.3-29bbeab0/00000009.sst
13M .next/cache/turbopack/v16.4.3-29bbeab0/00000008.sst
13M .next/cache/turbopack/v16.4.3-29bbeab0/00000005.sst
13M .next/cache/turbopack/v16.4.3-29bbeab0/00000003.sst
12M .next/cache/turbopack/v16.4.3-29bbeab0/00000020.sst
12M .next/cache/turbopack/v16.4.3-29bbeab0/00000019.sst
12M .next/cache/turbopack/v16.4.3-29bbeab0/00000011.sst
12M .next/cache/turbopack/v16.4.3-29bbeab0/00000004.sst
11M .next/cache/turbopack/v16.4.3-29bbeab0/00000006.sst
6.1M .next/static/chunks/1vu6vf_pg32i7.js
6.1M .next/server/chunks/ssr/src_app_dev_icons_page_tsx_0bmgqvoiobm8p._.js
4.3M .next/cache/turbopack/v16.4.3-29bbeab0/00000017.sst
3.6M .next/cache/turbopack/v16.4.3-29bbeab0/00000015.sst
3.5M .next/cache/turbopack/v16.4.3-29bbeab0/00000024.sst
3.1M .next/cache/turbopack/v16.4.3-29bbeab0/00000007.sst
3.1M .next/cache/turbopack/v16.4.3-29bbeab0/00000002.sst
3.1M .next/cache/turbopack/v16.4.3-29bbeab0/00000001.sst

@github-actions

Copy link
Copy Markdown

📦 번들 크기 분석 요약:

번들 크기 분석 결과

Next.js 빌드 출력 크기

221M .next

가장 큰 파일 상위 20개

15M .next/cache/turbopack/v16.4.3-29bbeab0/00000004.sst
13M .next/cache/turbopack/v16.4.3-29bbeab0/00000022.sst
13M .next/cache/turbopack/v16.4.3-29bbeab0/00000017.sst
13M .next/cache/turbopack/v16.4.3-29bbeab0/00000010.sst
13M .next/cache/turbopack/v16.4.3-29bbeab0/00000005.sst
13M .next/cache/turbopack/v16.4.3-29bbeab0/00000003.sst
12M .next/cache/turbopack/v16.4.3-29bbeab0/00000018.sst
12M .next/cache/turbopack/v16.4.3-29bbeab0/00000016.sst
12M .next/cache/turbopack/v16.4.3-29bbeab0/00000015.sst
12M .next/cache/turbopack/v16.4.3-29bbeab0/00000009.sst
11M .next/cache/turbopack/v16.4.3-29bbeab0/00000006.sst
9.8M .next/cache/turbopack/v16.4.3-29bbeab0/00000007.sst
6.1M .next/static/chunks/1vu6vf_pg32i7.js
6.1M .next/server/chunks/ssr/src_app_dev_icons_page_tsx_0bmgqvoiobm8p._.js
5.0M .next/cache/turbopack/v16.4.3-29bbeab0/00000012.sst
4.8M .next/cache/turbopack/v16.4.3-29bbeab0/00000011.sst
3.7M .next/cache/turbopack/v16.4.3-29bbeab0/00000020.sst
3.1M .next/cache/turbopack/v16.4.3-29bbeab0/00000008.sst
3.1M .next/cache/turbopack/v16.4.3-29bbeab0/00000002.sst
3.1M .next/cache/turbopack/v16.4.3-29bbeab0/00000001.sst

@github-actions

Copy link
Copy Markdown

✅ 코드 품질 검사가 완료되었습니다. 위 출력 결과에서 이슈를 확인하세요.

@github-actions

Copy link
Copy Markdown

⚡ Lighthouse 성능 감사가 완료되었습니다. 아티팩트에서 상세 리포트를 확인하세요.

@github-actions

Copy link
Copy Markdown

♿ 접근성 감사가 완료되었습니다. 아티팩트의 a11y-report를 확인하세요.

@github-actions

Copy link
Copy Markdown

📊 테스트 커버리지 리포트

테스트 커버리지 요약

사용 가능한 커버리지 데이터가 없습니다.

@github-actions

Copy link
Copy Markdown

🔍 CodeQL 보안 분석이 완료되었습니다. 세부 검출 결과는 리포지토리의 Security 탭을 확인하세요.

@github-actions

Copy link
Copy Markdown

✅ E2E 테스트가 완료되었습니다. 아티팩트에서 Playwright 리포트를 확인하세요.

@yshls
yshls merged commit 7ee6fc5 into develop Nov 18, 2026
19 checks passed
@github-actions

Copy link
Copy Markdown

✅ E2E 테스트가 완료되었습니다. 아티팩트에서 Playwright 리포트를 확인하세요.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant