Repository navigation
chore: remove the unpublished Node.js bindings - #448
Open
Nic-dorman wants to merge 1 commit into
Open
Nic-dorman wants to merge 1 commit into
Nic-dorman wants to merge 1 commit into
Conversation
@withautonomi/self-encryption was never published: npm has no such package and nodejs-publish.yml never ran. Nothing in WithAutonomi uses the bindings, and a napi addon is Node-only, so it can't serve browser use either. nodejs.yml still built and tested them on three OSes on every PR, with `contents: write` and `id-token: write`, and its push filter named `main`, which isn't this repo's default branch. Delete nodejs/ and both Node workflows. Drop the workspace member and the release-plz entry. The self_encryption crate itself doesn't change. Closes V2-1764 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2 of 7 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear issue
Closes V2-1764
Summary
This removes the Node.js (napi) bindings, which were never published. It's part of the 2026-10-27 faux-CI audit (V2-1747, item 3).
@withautonomi/self-encryptionis a 404 on npm, andnodejs-publish.yml(workflow_dispatch only) has 0 runs, so theNPM_TOKENsecret was never used. The versions had also drifted apart:nodejs/package.jsonsays 0.1.1 andnodejs/Cargo.tomlsays 0.1.0.nodejs.ymlbuilt and tested them on Linux, Windows and macOS on every PR, withcontents: write+id-token: writeon a test workflow. Its push filter namedmain, but the default branch ismaster.Removed:
nodejs/(the napi crate, JS shims, per-platform npm stubs and tests)..github/workflows/nodejs.ymlandnodejs-publish.yml.nodejsworkspace member, and theself-encryption-nodejsentry inrelease-plz.toml.The
[workspace]table stays (now root-only), and the CHANGELOG history is untouched.Not changed: the
self_encryptioncrate (nosrc/, dependency or feature changes) and the Python bindings. Fixing PyPI publishing is tracked separately in V2-1763.Admin follow-ups (not in this PR):
NPM_TOKENrepo secret.self-encryption-nodejs0.1.0 on crates.io. It was published on 2025-08-05, but a napicdylibisn't usable as a dependency.Risk tier
Compatibility
self_encryption. The removedself-encryption-nodejscrate wasrelease = falseand never reached npm.Semver impact
Test evidence
This mirrors merge.yml (
RUSTFLAGS=-D warnings) and release.yml. It was run on dev2 (Ubuntu 24.04) against master 656f96a plus this diff; the tested tree is byte-identical to this branch.cargo build --releasecargo build --release --workspace(release.yml)cargo clippy --all-targets --all-featurescargo test --releasecargo publish --dry-runcargo deny checkcargo metadataworkspace membersself_encryptiononlyNew dependency
none
ADR
n/a
Mitigation / rollback
Revert the PR. Nothing downstream consumes the bindings.
🤖 Generated with Claude Code