Skip to content

Default OAuth to HTTP/2 while honoring custom HttpClient settings #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matnun-br merged 3 commits into from
Nov 4, 2026
Merged

Default OAuth to HTTP/2 while honoring custom HttpClient settings #21

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d1c34c0
Prefer HTTP/2 for OAuth token requests
clement911 Nov 3, 2026
b8e47b4
Honor HttpClient default HTTP version and policy
clement911 Nov 3, 2026
dacce79
Default the built-in OAuth HttpClient to HTTP/2 with fallback
clement911 Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ShopifyNet/OAuth/ShopifyOAuthClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,11 @@ public class ShopifyOAuthClient
AutomaticDecompression = DecompressionMethods.All,
// Token requests must not forward credentials to a redirect target.
AllowAutoRedirect = false
});
})
{
DefaultRequestVersion = HttpVersion.Version20,
DefaultVersionPolicy = HttpVersionPolicy.RequestVersionOrLower
};

private readonly string _clientId;
private readonly string _clientSecret;
Expand Down Expand Up @@ -401,6 +405,8 @@ private async Task<T> RequestAccessTokenAsync<T>(string myShopifyDomain, Diction

using var request = new HttpRequestMessage(HttpMethod.Post, $"https://{myShopifyDomain}/admin/oauth/access_token")
{
Version = _httpClient.DefaultRequestVersion,
VersionPolicy = _httpClient.DefaultVersionPolicy,
Content = new FormUrlEncodedContent(parameters)
};
request.Headers.Accept.ParseAdd("application/json");
Expand Down
Loading