Repository navigation
Update project to query access tokens using the client assertion mechanism - #18
Merged
Merged
Conversation
… mechanism rather than relying on a static value which expires. All parameters are provided via environment variables
matnun-br
requested review from
clement911 and
greg-betterreports
and
a balanced review from Copilot
November 3, 2026 01:51
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the switch to client-assertion authentication.
No open issues 🎉
What changed in this PR
This PR switches the type generator and integration tests from a configured shop token to access tokens obtained through client assertion authentication.
Changes:
- Request access tokens using the client ID, key ID, and private key.
- Acquire one token during client-test class initialization and use fixed credentials for mocked token-bucket tests.
- Replace the shop-token secret in CI with client assertion credentials.
| File | Description |
|---|---|
ShopifyNet.TypeGenerator/TypeGenerator.cs |
Requests an access token and validates required environment variables. |
ShopifyNet.Tests/TokenBucket/TokenBucketInterceptorTests.cs |
Separates mocked credentials from live-test token acquisition. |
ShopifyNet.Tests/TestHelper.cs |
Adds credential accessors and a shared token-request helper. |
ShopifyNet.Tests/ShopifyClientTests.cs |
Obtains an access token during class initialization. |
.github/workflows/ci.yml |
Supplies client assertion secrets to the test step. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.