Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #35
Hi @antonfin! Thank you for merging #40 so quickly.
The problem
Packagist still doesn't learn about new commits of this repository: right now
composer require validator/livrinstallsdev-masterat28079c5(October 28), so users don't get LIVR 2.5 from #40, merged today. Without a hook, Packagist only crawls the repository about once a week. The LIVR test suite run on livr-spec.org installs the package from Packagist, so it shows PHP with the old code too (3 of 80 LIVR 2.5 cases).#34 was closed in favour of setting up Packagist's own GitHub integration (#35), but that hasn't happened yet. This PR is the other way: it doesn't need any settings on GitHub's side or access to the Packagist account's GitHub connection, only an API token.
What this PR does
It adds
.github/workflows/packagist.yml. After every push tomasterand every tag (and when started by hand), it calls Packagist'supdate-packageAPI, so the new code is on Packagist within a minute.What's needed from a maintainer
PACKAGIST_USERNAME: the packagist.org username of a maintainer ofvalidator/livr;PACKAGIST_TOKEN: that user's safe API token from https://packagist.org/profile/.masterwith LIVR 2.5 right away.Until the secrets are set, the workflow only shows a warning and passes, so it doesn't break anything. A wrong token fails the job (Packagist answers 403), so the problem is visible.
If you'd rather use Packagist's GitHub integration instead (as described in #35), that works too, and then this PR can be closed. Either way, clicking Update on https://packagist.org/packages/validator/livr now would give users LIVR 2.5 today.
This PR was prepared with the help of an LLM; it is the same workflow as in #34. Thank you!