Skip to content

fix(dart_pub_publish): make pub_credentials optional for OIDC publishing - #541

Merged
erickzanardo merged 4 commits into
mainfrom
vgv-ai-bot/issue-540
Oct 28, 2026
Merged

erickzanardo merged 4 commits into
mainfrom
vgv-ai-bot/issue-540

Conversation

@unicoderbot

@unicoderbot unicoderbot Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Summary

Makes pub_credentials a non-required secret so callers can use OIDC-based publishing without passing a dummy secret. Also adds an optional environment input to support GitHub deployment environments as recommended by dart.dev.

Changes

  • Changed pub_credentials secret from required: true to required: false
  • Added optional environment input (forwarded to the job's environment: field)
  • Updated documentation to reflect the new environment input

Why

The dart_pub_publish.yml workflow is documented as supporting automated publishing via OIDC, but marking pub_credentials as required: true caused workflow validation failures for callers who don't pass a secrets: block. This made OIDC-only publishing impossible without supplying a dummy secret.

Closes #540

Closes #540

Co-authored-by: marcossevilla <marcossevilla@users.noreply.github.com>
@unicoderbot

unicoderbot Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor Author

CI failed on this PR. I'm looking into it and will push a fix (attempt 1 of 3).

  • Preparing environment
    • Cloning repository
    • Setting up dev environment
  • Inspecting CI failures
  • Working on fix
  • Pushing fix

I've pushed a fix for the failing CI (attempt 1/3). Re-run CI to confirm.

Comment thread site/docs/workflows/dart_pub_publish.md
@erickzanardo

Copy link
Copy Markdown
Member

/unicoder address the comments

@unicoderbot

unicoderbot Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor Author

On it, I'll address the review comments and push the changes.

  • Preparing environment
    • Cloning repository
    • Setting up dev environment
  • Reviewing feedback
  • Working on changes
  • Pushing updates

I've pushed changes to address the feedback.

Co-authored-by: erickzanardo <erickzanardo@users.noreply.github.com>
Comment thread site/docs/workflows/dart_pub_publish.md
@erickzanardo

Copy link
Copy Markdown
Member

/unicoder address the code review comments

@unicoderbot

unicoderbot Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor Author

On it, I'll address the review comments and push the changes.

  • Preparing environment
    • Cloning repository
    • Setting up dev environment
  • Reviewing feedback
  • Working on changes
  • Pushing updates

I've pushed changes to address the feedback.

Co-authored-by: erickzanardo <erickzanardo@users.noreply.github.com>
@erickzanardo
erickzanardo merged commit a1493ba into main Oct 28, 2026
18 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in VGV Open Source 🦄 🧙🌟 Oct 28, 2026
@erickzanardo
erickzanardo deleted the vgv-ai-bot/issue-540 branch October 28, 2026 14:45
@vgvbot vgvbot mentioned this pull request Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

fix(dart_pub_publish): requires pub_credentials secret despite using OIDC

1 participant