Repository navigation
fix(dart_pub_publish): make pub_credentials optional for OIDC publishing - #541
Merged
Merged
Conversation
Closes #540 Co-authored-by: marcossevilla <marcossevilla@users.noreply.github.com>
Contributor
Author
Member
|
/unicoder address the comments |
Contributor
Author
Co-authored-by: erickzanardo <erickzanardo@users.noreply.github.com>
Member
|
/unicoder address the code review comments |
Contributor
Author
Co-authored-by: erickzanardo <erickzanardo@users.noreply.github.com>
erickzanardo
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
pub_credentialsa non-required secret so callers can use OIDC-based publishing without passing a dummy secret. Also adds an optionalenvironmentinput to support GitHub deployment environments as recommended by dart.dev.Changes
pub_credentialssecret fromrequired: truetorequired: falseenvironmentinput (forwarded to the job'senvironment:field)environmentinputWhy
The
dart_pub_publish.ymlworkflow is documented as supporting automated publishing via OIDC, but markingpub_credentialsasrequired: truecaused workflow validation failures for callers who don't pass asecrets:block. This made OIDC-only publishing impossible without supplying a dummy secret.Closes #540