Repository navigation
ci: add mypy - #25
Merged
Merged
ci: add mypy#25
Conversation
Owner
|
Thanks @rk042 , nice contribution. The package builds, mypy is clean on the 3.9 target, all 397 tests pass, and the workflow is valid. Merging. I'll make a small follow-up to move mypy into its own extra. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds mypy to the development dependencies and runs it against
src/booth/in a separate GitHub Actions job. The job runs on Python 3.12 while checking
compatibility with BOOTH's minimum supported Python version, Python 3.9.
Closes #17
Why?
BOOTH ships a
py.typedmarker, so type checkers trust its annotations.This CI check prevents those annotations from silently becoming stale.
Checklist
384 passed, 6 skipped.mypy src/booth/: no issues found in 2 source files.Anything else worth knowing?
Mypy is pinned to
>=1.19,<2.0. Python 3.12 is used to run mypy in CI,while
python_version = "3.9"checks compatibility with BOOTH's minimumsupported Python version.