Skip to content

feat(typing): add py.typed marker and package data (PEP 561) - #16

Merged
Vedantgitbot merged 1 commit into
Vedantgitbot:mainfrom
AK-Lmn:feat/py-typed-marker
Oct 8, 2026
Merged

Vedantgitbot merged 1 commit into
Vedantgitbot:mainfrom
AK-Lmn:feat/py-typed-marker

Conversation

@AK-Lmn

@AK-Lmn AK-Lmn commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Closes #15

Summary

Adds PEP 561 \py.typed\ inline type hints marker to allow external type checkers (mypy, pyright, Pylance) to inspect \�oothpy's type annotations.

Changes

  • Created \src/booth/py.typed.
  • Added [tool.setuptools.package-data]\ in \pyproject.toml\ to ensure \py.typed\ is packaged in built wheels and source distributions.
  • Added \�ttempt.confidence is not None\ check in \src/booth/core.py\ to resolve operand type comparison with \ hreshold\ in type checkers.

Verification

  • Verified wheel build via \python -m build\ confirms \�ooth/py.typed\ is included in \�oothpy-0.5.3-py3-none-any.whl.
  • Ran \mypy src/booth/: \Success: no issues found in 2 source files.
  • Ran \pytest: all 308 tests pass cleanly.

@Vedantgitbot

Copy link
Copy Markdown
Owner

Thanks @AK-Lmn , this is a clean first PR. Appreciate you calling out the None guard in core.py yourself and including the mypy and wheel verification. Merging now.

@Vedantgitbot
Vedantgitbot merged commit 27510b1 into Vedantgitbot:main Oct 8, 2026
4 checks passed
@Vedantgitbot Vedantgitbot mentioned this pull request Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add py.typed marker (PEP 561) to ship BOOTH's type hints to type checkers

2 participants