Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Pull Request Template
1. Related Issue
Closes #642
2. Type of Change (select one)
Type of Change: Bug Fix
3. Description
In
python/valuecell/server/services/conversation_service.py,get_conversation_listacceptslimitandoffsetparameters forwarded from theGET /conversationsendpoint. Whiletotal = len(conversations)was calculated, the conversation list was never sliced by[offset : offset + limit], causing the endpoint to return all conversations unconditionally regardless of requested pagination parameters.This PR applies pagination slicing to
conversationsusing[offset : offset + limit](with non-negative guards) after strategy conversations are filtered, ensuring that:totalstill correctly reflects the total count of non-strategy conversations.4. Testing
Added unit tests in
python/valuecell/server/services/tests/test_server_conversation_service.py:test_get_conversation_list_applies_limit_and_offset: verifies correct window slicing and element order.test_get_conversation_list_offset_beyond_total: verifies graceful handling of offsets exceeding total count.test_get_conversation_list_excludes_strategy_agents_before_pagination: verifies filtering order relative to total count and pagination.Ran full test suite (
uv run pytest: 404 passed), code formatting (ruff format), and linting (ruff check: all checks passed).5. Checklist