Skip to content

Handle documented VuMark generation failures - #3120

Merged
adamtheturtle merged 2 commits into
mainfrom
adamtheturtle/expand-mock-3090
Aug 5, 2026
Merged

adamtheturtle merged 2 commits into
mainfrom
adamtheturtle/expand-mock-3090

Conversation

@adamtheturtle

@adamtheturtle adamtheturtle commented Aug 5, 2026 •

Copy link
Copy Markdown
Member

Closes #3090.

Previously, documented VuMark generation failure result codes were not registered and therefore surfaced as KeyError.
This adds public exceptions, result-code mappings, and sync/async documentation, then pins vws-python-mock==2026.8.4.2 and tests both clients through its real mocked HTTP routes.
Validation: uv run --extra dev pytest -q (331 passed), the full pre-commit suite with project-scoped vulture, and the full pre-push suite.


Note

Low Risk
Additive exception types and mappings with no change to existing error handling paths; covered by new parametrized tests.

Overview
Adds QuotaExceededError, LicenseCheckFailedError, and AuthorizationFailedError and wires them into the existing Vuforia result_code → exception registry so documented VuMark generation failures surface as typed VWSError subclasses instead of KeyError.

VuMarkService and AsyncVuMarkService docstrings now document these raises. Dev dependency vws-python-mock is bumped to 2026.8.4.2; sync and async tests use VuMarkGenerationFailure to assert the right exception and HTTP status for each code.

Reviewed by Cursor Bugbot for commit 6fdd76d. Bugbot is set up for automated code reviews on this repo. Configure here.

@adamtheturtle
adamtheturtle marked this pull request as ready for review August 5, 2026 09:37
@adamtheturtle
adamtheturtle merged commit 91a5138 into main Aug 5, 2026
14 checks passed
@adamtheturtle
adamtheturtle deleted the adamtheturtle/expand-mock-3090 branch August 5, 2026 10:05

This branch was previously deployed

1 inactive deployment
development — 6fdd76d8 Deployed Aug 5, 2026 by adamtheturtle via pages #867
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documented VuMark error codes raise KeyError

1 participant