Repository navigation
Open verified team entries through the remembered social provider - #133
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Signed-in people entering another team had to choose their provider and team again in UOA. An explicit browser team entry now uses the previously completed, still-enabled social provider as a UI preference, performs the normal provider roundtrip, and opens the verified target without those extra choices.
Verification
Passed on Maxis:
No native build was performed. Required CI passed and deployment 40115923985 succeeded. Cloud Run revision uoa-auth-00348-hk5 serves 100% of traffic; its image digest matches merge 503579e and the health endpoint passed. Live integrated-browser verification with the relying product and real Google sign-in passed: one initial provider confirmation established the preference, then a different target and repeat team entries completed without further provider or team choices. Reloads preserved the selected team.
Journey evidence
These are actual built Auth HTML/React and UOA routes against an isolated database, using the same light theme, configuration and viewports. Before uses product sources at
ee2bf654; After usesaaaf6930. Google HTTP and signed configuration are local fixtures. No screenshot shows Google's UI. Source/target completion pages are explicitly labelled local callback fixtures, and do not claim to show Nessie's product UI. Live Google and the complete product journey were verified separately after deployment, as described above; the images here remain isolated fixture evidence.The existing generic cancellation page is unchanged. The next explicit entry returns to provider choices. After's provider-choice screen is skipped, so there is no replacement screenshot for that absent screen; the next screenshot shows its automatic team-opening state.
Desktop: 1280 × 900
0. Source sign-in has completed (labelled callback fixture)
Before — desktop, 1280 × 900.
After — desktop, 1280 × 900.
1. New target-team entry reaches provider choice
Before — desktop, 1280 × 900.
After: Not rendered. The remembered enabled provider starts its real protocol roundtrip automatically; the next state is shown below.
2. Choose the target team or open it automatically
Before — desktop, 1280 × 900.
After — desktop, 1280 × 900.
3. Exact target sign-in completes (labelled callback fixture)
Before — desktop, 1280 × 900.
After — desktop, 1280 × 900.
4. A subsequent provider attempt is cancelled (existing HTTP 401 page)
Before — desktop, 1280 × 900.
After — desktop, 1280 × 900.
5. The next explicit entry returns to provider choices
Before — desktop, 1280 × 900.
After — desktop, 1280 × 900.
Mobile: 390 × 900
0. Source sign-in has completed (labelled callback fixture)
Before — mobile, 390 × 900.
After — mobile, 390 × 900.
1. New target-team entry reaches provider choice
Before — mobile, 390 × 900.
After: Not rendered. The remembered enabled provider starts its real protocol roundtrip automatically; the next state is shown below.
2. Choose the target team or open it automatically
Before — mobile, 390 × 900.
After — mobile, 390 × 900.
3. Exact target sign-in completes (labelled callback fixture)
Before — mobile, 390 × 900.
After — mobile, 390 × 900.
4. A subsequent provider attempt is cancelled (existing HTTP 401 page)
Before — mobile, 390 × 900.
After — mobile, 390 × 900.
5. The next explicit entry returns to provider choices
Before — mobile, 390 × 900.
After — mobile, 390 × 900.
Full screenshot inventory, revisions, fixture limits and local commands.