Skip to content

[pull] master from gchq:master #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 2 commits into from
Sep 9, 2026
Merged

[pull] master from gchq:master #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d1d62e
test: stabilise autobake UI test (#2781)
sylvesterkaczmarek Sep 9, 2026
1d5f84b
chore (deps): bump morgan from 1.11.0 to 1.12.0 (#2793)
dependabot[bot] Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

36 changes: 28 additions & 8 deletions tests/browser/01_io.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,20 +178,40 @@ module.exports = {
browser.click("#auto-bake-label");
browser.expect.element("#auto-bake").to.be.selected.before(1000);

// Record the transient loader state without polling for visibility at one instant.
// The loader is deliberately delayed by 200ms, so waiting to observe it directly is flaky.
browser.execute(function() {
const loader = document.getElementById("output-loader");
window.autobakeLoaderWasVisible = loader.style.visibility === "visible";
window.autobakeLoaderObserver = new MutationObserver(function() {
if (loader.style.visibility === "visible") {
window.autobakeLoaderWasVisible = true;
}
});
window.autobakeLoaderObserver.observe(loader, {
attributes: true,
attributeFilter: ["style"]
});
});

// Add content to the input
browser.pause(100);
browser.sendKeys("#input-text .cm-content", "1");
browser.waitForElementVisible("#output-loader");
browser.waitForElementNotVisible("#stale-indicator", 5000);
browser.pause(500);

// Make another change while the previous input is being baked
browser
.sendKeys("#input-text .cm-content", "2")
.waitForElementNotVisible("#stale-indicator")
.waitForElementNotVisible("#output-loader");

// Ensure we got the latest input baked
utils.expectOutput(browser, "input12");
browser.sendKeys("#input-text .cm-content", "2");

// Wait for the latest input rather than the delayed loading animation.
browser.expect.element("#output-text .cm-content").text.to.equal("input12").before(10000);
browser.waitForElementNotVisible("#output-loader", 10000);
browser.execute(function() {
window.autobakeLoaderObserver.disconnect();
return window.autobakeLoaderWasVisible;
}, [], function({value}) {
browser.expect(value).to.equal(true);
});

// Turn autobake off again
browser.click("#auto-bake-label");
Expand Down