Repository navigation
refactor(project): Name one run of a step an invocation - #1654
Merged
Merged
Conversation
Give one execution of a step a consistent name. A map step (keys/each) has one invocation per key; a scalar step (run) has exactly one invocation. The term pairs with the existing invocationData the StepRunner persists per key. Replace the previous mixed use of "unit" in StepRunner, the build cache, and the related tests, docs, and skill notes. Rename the internal callback parameter unitCtx to invocationCtx. Keep "unit" where it means something else: "unit test", "unit of caching", a module path, or a measurement unit. JIRA: CPOUI5FOUNDATION-1388
matz3
added a commit
that referenced
this pull request
Oct 12, 2026
Apply the terminology from #1654 to the incremental-build RFC. Replace the mixed use of "unit" for one run of a step with "invocation" in the step-based-task sections. Keep "unit" where it means the unit of caching. JIRA: CPOUI5FOUNDATION-1388
RandomByte
previously approved these changes
Oct 12, 2026
codeworrior
previously approved these changes
Oct 13, 2026
Rename the step-grained internals that actually operate on the per-key grain to use the invocation name. A recorder is created once per invocation, the per-key worker runs once per invocation, and the selection method filters per-key entries, so none of them are step-grained: - StepRecorder -> InvocationRecorder, stepIndex -> invocationIndex - the per-key worker arrow function runStep -> runInvocation - the private method #selectStepsToRun -> #selectInvocationsToRun The step-grained names stay: the public runSteps method and the @ui5/builder runSteps task helper, #computeStepReturnSignature which folds every key into one step signature, and #notifyStepExecution with the anyStepExecuted / notifyStepExecution boundary names. A step is the authored unit, an invocation is one run of it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Give one execution of a step a consistent name. A map step (keys/each) has one invocation per key; a scalar step (run) has exactly one invocation. The term pairs with the existing invocationData the StepRunner persists per key.
Replace the previous mixed use of "unit" in StepRunner, the build cache, and the related tests, docs, and skill notes. Rename the internal callback parameter unitCtx to invocationCtx. Keep "unit" where it means something else: "unit test", "unit of caching", a module path, or a measurement unit.
JIRA: CPOUI5FOUNDATION-1388