Repository navigation
Added elements for SideInDirectionOfTravel - #240
Open
PatrickGoudvis wants to merge 2 commits into
Open
PatrickGoudvis wants to merge 2 commits into
PatrickGoudvis wants to merge 2 commits into
Conversation
skinkie
previously approved these changes
Oct 2, 2026
skinkie
left a comment
skinkie
left a comment
Contributor
There was a problem hiding this comment.
The only corner case I was able to think of was a variant where a formation would split, and two parts would do something else. The direction of travel may be different. Splitting, and leaving in another direction is not something extreme but maybe someone else has a strong opinion about it. For me this would be sufficient.
Collaborator
|
The PR needs to be reworked to define the type Also, this is a prime candidate for aligning types between NeTEx & SIRI |
haeckerbaer
requested review from
Aurige,
BredeD,
DohmenClaus,
TuThoThai,
Ulf9,
haeckerbaer,
skinkie,
thbar,
tim-rivett and
ue71603
October 2, 2026 15:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added two optional elements to indicate the actual SideInDirectionOfTravel for MonitoredStops in Journeys