Skip to content

Adding DeadRun flag to SIRI for ET and VM - #238

Merged
TuThoThai merged 14 commits into
v2.3-wipfrom
vm_cr_deadrun
Oct 2, 2026
Merged

TuThoThai merged 14 commits into
v2.3-wipfrom
vm_cr_deadrun

Conversation

@TuThoThai

Copy link
Copy Markdown
Collaborator

Context

Since we have the possibility to have dead runs in NeTEx, it would be interesting to be able to follow them in SIRI-VM (mostly) and in SIRI-ET. It would allow to address these use cases:

  • Have an explicit mention of a dead run that can be used for passenger information, especially when unplanned
  • Support fleet monitoring regardless of the ServiceJourney type (accepting passengers or not).

Changes made in this PR

  • In the XSD, more precisely in siri_journey.xsd in the JourneyInfoGroup, addition of an optional boolean named DeadRun7 with the default value being false`
  • One example of a payload in SIRI-ET that includes a dead run
  • One example of a payload in SIRI-VM that includes a dead run

Addition of:
- DeadRun flag as a boolean in JouneyInfoGroup
- Example in SIRI-ET
- Example in SIRI-VM
@TuThoThai TuThoThai added this to the v2.3 milestone Aug 11, 2026
@TuThoThai TuThoThai added ET For everything SIRI-ET VM For everything SIRI-VM labels Aug 11, 2026
haeckerbaer
haeckerbaer previously approved these changes Sep 16, 2026

@haeckerbaer haeckerbaer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved but maybe check the sentence "so it is clear that only there is no expectation of an associated service to it" again.

Clarification of the documentation for the DeadRun flag based on suggestion by @haeckerbaer
@TuThoThai

Copy link
Copy Markdown
Collaborator Author

@haeckerbaer, thanks for pointing the unclear documentation. I have fixed it for your review!

haeckerbaer
haeckerbaer previously approved these changes Sep 29, 2026
@Ulf9

Ulf9 commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator
  1. I think there is a problem having a default value in relation to backward compatibility. Currently the element does not exist and that means it is undefined. It is not limited to be only a ServiceJourney, it could be a DeadRun as well.

So if this new element is to be added there should not be any deafult-value. Instead if used it must be explicit if the value is false or true.

  1. Maybe it should instead by named differently with an enumeration DEAD_RUN, SERVICE_JOURNEY

Comment thread xsd/siri_model/siri_journey.xsd Outdated
Comment thread examples/siri_exm_ET/ext_estimatedTimetable_response_deadrun.xml
Comment thread examples/siri_exm_ET/ext_estimatedTimetable_response_deadrun.xml
- In the XSD, the boolean is now `IsDeadRun` and has no default value
- Name of the boolean changed in both examples
- In the ET example, addition of calls for the dead run
@TuThoThai

Copy link
Copy Markdown
Collaborator Author

As per the SIRI plenary meeting of 29 September 2026, the PR is approved with the following changes:

  • change the boolean name to IsDeadRun
  • remove the default value to the boolean
  • edit the examples consequently
  • in the ET example, add Calls for the dead run

Changes have just been committed, so the PR is ready for your review @albanpeignier, @Aurige, @haeckerbaer, @skinkie, @thbar, @Ulf9

@TuThoThai TuThoThai mentioned this pull request Oct 2, 2026
11 of 12 tasks
Comment thread xsd/siri_model/siri_journey.xsd Outdated
Comment thread xsd/siri_model/siri_journey.xsd Outdated
based on review by @skinkie

Co-authored-by: Stefan de Konink <stefan@konink.de>
@TuThoThai
TuThoThai requested a review from skinkie October 2, 2026 09:54
haeckerbaer
haeckerbaer previously approved these changes Oct 2, 2026
Aurige
Aurige previously approved these changes Oct 2, 2026
@TuThoThai

Copy link
Copy Markdown
Collaborator Author
  1. I think there is a problem having a default value in relation to backward compatibility. Currently the element does not exist and that means it is undefined. It is not limited to be only a ServiceJourney, it could be a DeadRun as well.

So if this new element is to be added there should not be any deafult-value. Instead if used it must be explicit if the value is false or true.

2. Maybe it should instead by named differently with an enumeration DEAD_RUN, SERVICE_JOURNEY

Investigation was done for the the use of an enumeration coming from NeTEx. Making this element an enumeration would have forced to have the values for different types of Dead Run but also Service Alteration.
As of NeTEx v2.0, there is no more enumeration that would distinguish only Dead Run from other types of Service Journey

@TuThoThai
TuThoThai merged commit 495697a into v2.3-wip Oct 2, 2026
1 check passed
@TuThoThai
TuThoThai deleted the vm_cr_deadrun branch October 2, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ET For everything SIRI-ET VM For everything SIRI-VM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants