Repository navigation
Adding elements to ActionDataStructure in SIRI-SX to facilitate sharing of audio & video messages - #210
Merged
Conversation
TuThoThai
added
SX
ue71603
reviewed
Apr 22, 2026
ue71603
previously approved these changes
Apr 22, 2026
skinkie
reviewed
May 12, 2026
haeckerbaer
previously approved these changes
May 13, 2026
haeckerbaer
left a comment
haeckerbaer
left a comment
Collaborator
There was a problem hiding this comment.
nothing to add if skinkie's comment is taken care of
Collaborator
Author
|
I have applied @skinkie suggestion. For the type of the attribute, let's go with str for now and see if it needs to be updated once used. |
Collaborator
Author
|
Example created, which led to the edit of the XSD to move the 2 attributes of the |
skinkie
reviewed
May 17, 2026
Collaborator
Author
|
@skinkie, it ended up a tad more complicated than my original proposal to ensure both the XSD and the example validate. Kindly help with another review. |
skinkie
reviewed
May 17, 2026
skinkie
reviewed
May 17, 2026
skinkie
reviewed
May 17, 2026
skinkie
reviewed
May 18, 2026
- Change in `Prompt` to embed MIME content type - Addition of `Url` with a specific type to embed MIME content type and language - All served with an example
Merged
TuThoThai
force-pushed
the
sx_cr_audiomessage
branch
from
July 15, 2026 17:59
1d18f6e to
b26631e
Compare
Collaborator
Author
|
After the meeting of 19 May 2026, I did the following:
|
TuThoThai
marked this pull request as ready for review
July 15, 2026 18:02
haeckerbaer
previously approved these changes
Jul 28, 2026
TuThoThai
commented
Sep 29, 2026
- List of additions in the XSD at the top of the Schema in the section for comments - Change of the name of the type of value for URI content type - Correction of typos in the XSD documentation - Addition of content types in the enumeration for video + cleanup of values not used for broadcast
- Additing elements for the repetition of Action Data element in its structure - Adjusting the example on changes made to Action Data Structure
…system/SIRI into sx_cr_audiomessage
Collaborator
Author
|
This PR is to be merged after PR #221
This PR is now ready for your review @Aurige, @haeckerbaer, @skinkie, @thbar, @ue71603 and @Ulf9 |
11 of 12 tasks
haeckerbaer
previously approved these changes
Oct 2, 2026
thbar
approved these changes
Oct 2, 2026
TuThoThai
changed the title
haeckerbaer
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refers to the discussion on BaseCamp for adding pre-recorded audio messages when a situation occurs.
Change done only in
siri_situationActions.xsdwith:PublishToAudioActioninActionsGroupPublishToAudioActionStructurebased onParametrisedActionStructurewith the extension of URL for the pre-recorded messageTo be discussed in the SIRI-SX task force