Repository navigation
fix: clear the four ganda repo audit failures - #44
Merged
StevenTCramer merged 5 commits intoNov 9, 2026
Merged
StevenTCramer merged 5 commits into
StevenTCramer merged 5 commits into
Conversation
Walk signal logs were unignored, the suppression baseline was missing, and the dev CLI pins lagged the versions the audit treats as current. Commit the --fix baseline so a later package move does not revert it. why: task 035 Co-Authored-By: grok <noreply@x.ai>
The audit baseline left the compiler packages on 4.11, and Nuru 4.0.0-beta.12 no longer has ICommandHandler. The generator stays on netstandard2.0 because Roslyn 5.9 still ships that framework. why: task 035 Co-Authored-By: grok <noreply@x.ai>
StevenTCramer
deleted the
task/035-bring-ganda-repo-audit-clean-and-update-nuget-pack
branch
November 9, 2026 17:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The live audit matched the 2026-11-09 snapshot: four Failed rows, all fixable.
ganda repo audit --fixseeded.timewarp/suppression-baseline.json, ignored/.timewarp/signals/, wrote the gitignored.vscode/settings.json, and moved the dev CLI pins. That diff is commit04e747a. A secondganda nuget outdatedthen moved the three Roslyn packages to 5.9.0. After both steps,ganda nuget outdatedreports all 10 central packages up to date.ganda repo audit --fixalso setTimeWarp.Terminalto2.0.0-beta.1. The pre-fix outdated run had called1.0.2current. The post-fix outdated run calls2.0.0-beta.1current, so the pin stayed.Microsoft.CodeAnalysis.CSharp5.9.0 still shipsnetstandard2.0. The generator target stayednetstandard2.0. The analyzer sources and tests compiled without API edits../bin/dev buildis 0 warnings and 0 errors../bin/dev testpasses, including the 11 TW0007 analyzer tests.Nuru 4.0.0-beta.12 pulls TimeWarp.Mediator 15, which removed
ICommandHandler. The four local handlers implementIRequestHandler<T, Unit>and returnValueTask<Unit>.check-versionandreleasenow takeNuGetVersionService, soIRepoCheckVersionServiceis no longer registered.NuGetPackageServiceis constructed in the workflow handler. Its greediest public constructor needsHttpMessageHandler, and registering that type would select the test seam. The parameterless constructor keeps the process-wide cache and avoids NURU051../bin/dev --helplistsrelease../bin/dev check-versionnamesTimeWarp.SourceGeneratorsand exits 1 because1.0.0-beta.12is already on nuget.org. That gate is the existing package version, not these pins.Review disposition
general.--help(listsrelease),check-version(seesTimeWarp.SourceGenerators),ganda repo audit(exit 0), andganda nuget outdated(10/10 current). All passed.review/review-framework.md,review/round-1/general.md,review/round-1/merged.md,review/disposition.md.Test plan
Smoke:
Expect:
ganda repo auditexits 0. The table has no Failed row (this run: Passed 39, Failed 0, Skipped 3).ganda nuget outdatedprintsAll packages are up to date!for the ten central packages, including Roslyn 5.9.0, Nuru and DevCli4.0.0-beta.12, Amuru and Amuru.Tools3.0.0-beta.2, and Terminal2.0.0-beta.1../bin/dev buildexits 0 with 0 errors. The generator output isnetstandard2.0../bin/dev testexits 0. The analyzer suite printsPassed: 11 Failed: 0../bin/dev --helplists thereleasecommand../bin/dev check-versionprintsPackages checked: TimeWarp.SourceGenerators. Exit 1 with "already released" means1.0.0-beta.12is still the package version.git ls-files '.timewarp/signals/*'prints nothing..vscode/settings.jsonis ignored..timewarp/suppression-baseline.jsonis tracked.Kanban task 035
Session: Grok --fix