Skip to content

fix: clear the four ganda repo audit failures - #44

Merged
StevenTCramer merged 5 commits into
masterfrom
task/035-bring-ganda-repo-audit-clean-and-update-nuget-pack
Nov 9, 2026
Merged

StevenTCramer merged 5 commits into
masterfrom
task/035-bring-ganda-repo-audit-clean-and-update-nuget-pack

Conversation

@StevenTCramer

Copy link
Copy Markdown
Contributor

Summary

The live audit matched the 2026-11-09 snapshot: four Failed rows, all fixable. ganda repo audit --fix seeded .timewarp/suppression-baseline.json, ignored /.timewarp/signals/, wrote the gitignored .vscode/settings.json, and moved the dev CLI pins. That diff is commit 04e747a. A second ganda nuget outdated then moved the three Roslyn packages to 5.9.0. After both steps, ganda nuget outdated reports all 10 central packages up to date.

ganda repo audit --fix also set TimeWarp.Terminal to 2.0.0-beta.1. The pre-fix outdated run had called 1.0.2 current. The post-fix outdated run calls 2.0.0-beta.1 current, so the pin stayed.

Microsoft.CodeAnalysis.CSharp 5.9.0 still ships netstandard2.0. The generator target stayed netstandard2.0. The analyzer sources and tests compiled without API edits. ./bin/dev build is 0 warnings and 0 errors. ./bin/dev test passes, including the 11 TW0007 analyzer tests.

Nuru 4.0.0-beta.12 pulls TimeWarp.Mediator 15, which removed ICommandHandler. The four local handlers implement IRequestHandler<T, Unit> and return ValueTask<Unit>. check-version and release now take NuGetVersionService, so IRepoCheckVersionService is no longer registered. NuGetPackageService is constructed in the workflow handler. Its greediest public constructor needs HttpMessageHandler, and registering that type would select the test seam. The parameterless constructor keeps the process-wide cache and avoids NURU051.

./bin/dev --help lists release. ./bin/dev check-version names TimeWarp.SourceGenerators and exits 1 because 1.0.0-beta.12 is already on nuget.org. That gate is the existing package version, not these pins.

Review disposition

  • Outcome: clean. 1 round, effort 2, roster general.
  • Final counts: bug 0, suggestion 0, nit 0. Open 0, fixed 0, wontfix 0.
  • The reviewer re-ran build (0 warnings, 0 errors), test (11/11), --help (lists release), check-version (sees TimeWarp.SourceGenerators), ganda repo audit (exit 0), and ganda nuget outdated (10/10 current). All passed.
  • Follow-up, not blocking: the Roslyn 5.9.0 bump raises the minimum host compiler for consumers (older SDKs or Visual Studio report CS8032, and the analyzers do not load). Document the floor before the next release.
  • Paths: review/review-framework.md, review/round-1/general.md, review/round-1/merged.md, review/disposition.md.

Test plan

Smoke:

ganda repo audit
ganda nuget outdated
./bin/dev build
./bin/dev test
./bin/dev --help
./bin/dev check-version
git ls-files '.timewarp/signals/*'
git check-ignore -v .vscode/settings.json

Expect:

  • ganda repo audit exits 0. The table has no Failed row (this run: Passed 39, Failed 0, Skipped 3).
  • ganda nuget outdated prints All packages are up to date! for the ten central packages, including Roslyn 5.9.0, Nuru and DevCli 4.0.0-beta.12, Amuru and Amuru.Tools 3.0.0-beta.2, and Terminal 2.0.0-beta.1.
  • ./bin/dev build exits 0 with 0 errors. The generator output is netstandard2.0.
  • ./bin/dev test exits 0. The analyzer suite prints Passed: 11 Failed: 0.
  • ./bin/dev --help lists the release command.
  • ./bin/dev check-version prints Packages checked: TimeWarp.SourceGenerators. Exit 1 with "already released" means 1.0.0-beta.12 is still the package version.
  • git ls-files '.timewarp/signals/*' prints nothing. .vscode/settings.json is ignored. .timewarp/suppression-baseline.json is tracked.

Kanban task 035
Session: Grok --fix

StevenTCramer and others added 5 commits November 9, 2026 23:46
Walk signal logs were unignored, the suppression baseline was missing,
and the dev CLI pins lagged the versions the audit treats as current.
Commit the --fix baseline so a later package move does not revert it.

why: task 035

Co-Authored-By: grok <noreply@x.ai>
The audit baseline left the compiler packages on 4.11, and Nuru
4.0.0-beta.12 no longer has ICommandHandler. The generator stays on
netstandard2.0 because Roslyn 5.9 still ships that framework.

why: task 035

Co-Authored-By: grok <noreply@x.ai>
@StevenTCramer
StevenTCramer merged commit e8dc4cc into master Nov 9, 2026
1 check passed
@StevenTCramer
StevenTCramer deleted the task/035-bring-ganda-repo-audit-clean-and-update-nuget-pack branch November 9, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant