Repository navigation
chore(audit): apply ganda repo audit --fix - #39
Merged
Merged
Conversation
The live audit still failed on glossary, hooks, the Nuru pin, required gitignore entries, vscode settings, the window icon, and pull_request branches. --fix is the baseline, including the Amuru 3 and Terminal pin moves that came with the Nuru bump. why: task 030
Charset, the self-package analyzer downgrade, and the markdown docs split are the rows --fix cannot take. Nuru 4 moved ICommand and Unit to TimeWarp.Mediator and returns Task, and the Amuru 3 pin is net11-only, so the dev CLI and the git hooks target net11 and CI installs that SDK. why: task 030
The audit is clean and the validation commands have been run. Task 027 is archived on master so it does not edit the same gitignore. why: task 030
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ganda repo auditexits 0 with no Failed row (Passed 36, Failed 0, Skipped 3).global-usings-analyzeris off under[ganda.audit]with the reason comment, and there is no rootPackageReferencetoTimeWarp.SourceGenerators.--fixis committed as0eac4eb(chore(audit): apply ganda repo audit --fix). That commit keeps the Amuru 3 and Terminal bumps. Hand fixes area936c58.Nuru and DevCli are 4.0.0-beta.11. Nuru 4 moved
ICommand,ICommandHandler, andUnittoTimeWarp.Mediator, and handlers returnTask<Unit>. The dev CLI compiles on net11.0.dotnet run --file tools/dev-cli/dev.cs -- --helplistsrelease.check-versionprintsPackages checked: TimeWarp.SourceGeneratorsand exits 1 because1.0.0-beta.11is already on NuGet. That exit is the release guard, not a missed package.markdown-docs-generator.csis 136 lines. Markdown parsing lives inmarkdown-docs-generator.markdown-to-xml.cs(409 lines)../bin/dev buildsucceeded with 0 warnings../bin/dev testpassed the test console and 11/11 analyzer tests. The Nuru 4 dev CLIbuildcommand also succeeded.Task 027 is archived on master (
09a725d). This walk did not runganda kanban doneorgh pr create.CI installs the net11 RC next to net10 so
dotnet run --file tools/dev-cli/dev.cscan restore Amuru 3. .NET 11 was still11.0.0-rc.3on 2026-11-08.Review disposition
ganda repo auditexit 0 (Passed 36, Failed 0, Skipped 3)../bin/dev buildreported 0 warnings and 0 errors../bin/dev testpassed 11/11.check-versionlistsTimeWarp.SourceGenerators. The generator split is confirmed as a pure move.11.0.100-rc.3.26522.148to11.0.x.review/review-framework.md,review/round-1/general.md,review/round-1/merged.md,review/disposition.md.Test plan