Skip to content

fix(editor): restore smooth Page Up/Down navigation - #271

Merged
ThisIs-Developer merged 2 commits into
mainfrom
fix/263-editor-page-navigation
Oct 7, 2026
Merged

ThisIs-Developer merged 2 commits into
mainfrom
fix/263-editor-page-navigation

Conversation

@ThisIs-Developer

@ThisIs-Developer ThisIs-Developer commented Oct 7, 2026 •

Copy link
Copy Markdown
Owner

Fixes #263.

Page Up/Down in the focused Editor could shift the entire workspace left and leave blank space on the right. Editor paging could also jump instantly instead of animating, and delayed synchronized scroll events could interrupt an ongoing animation.

Closed Settings dropdowns previously remained in the layout with display: block; visibility: hidden, adding 224px of horizontal overflow before Popper positioned them. Closed dropdowns now use display: none, while opening/closing transitions are preserved. The original issue was reproduced in Windows Edge at 100% zoom and display scale with the default Welcome document.

For Editor paging, the browser still chooses the destination, moves the caret, and extends Shift selections. When a native page scroll finishes immediately, a smooth-scroll fallback animates that same destination before painting; native animations are left intact. The fallback respects reduced motion and applies to both Editors. Synchronized scroll destinations are tracked using the browser's actual rounded/clamped offsets, preventing delayed target events from feeding back into the source animation. Scroll-sync release timers are also canceled when superseded.

The shared web/PWA assets and desktop resources are synchronized. The usage guide and changelog describe the behavior.

Welcome document, 1912px viewport Before After
Outer app horizontal scroll after Page Down 224px 0px
Workspace left edge -224px 0px
Editor left edge 84px 308px

Validation:

  • Paging and startup/smoke coverage in Chromium, Firefox, and WebKit: 45 passed, including native selection, repeated keys, reduced motion, secondary Editor, and a 375px mobile viewport.
  • Installed Windows Edge 154.0.4258.62: 11 paging tests passed.
  • The animation regression test fails against the previous PR implementation (7bba274) because it only paints the starting and final scroll positions; it passes with the fix.
  • Full npm test pipeline: build and SEO checks, 22 unit tests, and all 242 Chromium end-to-end tests passed.
  • node desktop-app/prepare.js completed successfully; generated web/desktop assets are synchronized.
  • git diff --check passed.

Mobile coverage uses browser viewports; the shared code also ships in the web/PWA and prepared desktop resources.

Original horizontal shift, reproduced during investigation

Workspace shifted left with a blank strip on the right

@vercel

vercel Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
markdown-viewer Ready Ready Preview Oct 7, 2026 2:14pm UTC

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Deploying markdownviewer with  Cloudflare Pages  Cloudflare Pages

Latest commit: ee2b3c9
Status: ✅  Deploy successful!
Preview URL: https://40167d24.markdownviewer.pages.dev
Branch Preview URL: https://fix-263-editor-page-navigati.markdownviewer.pages.dev

View logs

@wwdd48s8km-bit wwdd48s8km-bit left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! The original issue is resolved.

I did notice one regression, though: Page Up/Down in the Editor no longer has the smooth scrolling animation it had before. Page Up/Down in the Preview still scrolls smoothly.

Could you please check if the fix affects the Editor's scroll behavior?

@ThisIs-Developer

Copy link
Copy Markdown
Owner Author

Thanks for the fix! The original issue is resolved.

I did notice one regression, though: Page Up/Down in the Editor no longer has the smooth scrolling animation it had before. Page Up/Down in the Preview still scrolls smoothly.

Could you please check if the fix affects the Editor's scroll behavior?

Thanks for the quick reply and for confirming that the original issue has been fixed.

Regarding the smooth scrolling animation in the Editor section, I’m checking it now and trying to fix that behavior as well. Thanks for pointing it out!

@ThisIs-Developer ThisIs-Developer added bug Something is broken or not working as expected. ui/ux User interface, layout, interaction, usability, or visual improvements. labels Oct 7, 2026 — with ChatGPT Codex Connector
@ThisIs-Developer ThisIs-Developer changed the title fix(editor): prevent Page Up/Down from shifting the workspace fix(editor): restore smooth Page Up/Down navigation Oct 7, 2026
@ThisIs-Developer
ThisIs-Developer merged commit 0fc48c8 into main Oct 7, 2026
5 checks passed
@ThisIs-Developer
ThisIs-Developer deleted the fix/263-editor-page-navigation branch October 7, 2026 17:01

This branch was successfully deployed

1 active deployment
Preview — ee2b3c97 Deployed Oct 7, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something is broken or not working as expected. ui/ux User interface, layout, interaction, usability, or visual improvements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Page Up/Down shifts split view horizontally

2 participants