Repository navigation
test(windows-e2e): don't fail on a wait dialog that is still closing - #327
Merged
Merged
Conversation
…ing it unexpected When the running copy exits quickly, the second copy's wait dialog can still be closing, with only its title left, when Wait-Ready looks for dialogs; the release run for 2026.10.17 failed on that once. Look again after two seconds and fail only if a dialog is still there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows end-to-end check in the release pipeline failed once for 2026.10.17: the first copy exited quickly, and the second copy's wait dialog was still closing (only its title left) when
Wait-Readyscanned for dialogs, so it was reported as an unexpected dialog. The app itself behaved correctly; a rerun of the job passes.Wait-Readynow looks again two seconds after it first sees a dialog and fails only if one is still there.This script only runs in the release and
rehearse/**pipelines, so it will be exercised by the next release.🤖 Generated with Claude Code