Skip to content

Merge dev → main (automated) - #2091

Merged
SorraTheOrc merged 29 commits into
mainfrom
release/dev-to-main-20261004111450
Oct 4, 2026
Merged

SorraTheOrc merged 29 commits into
mainfrom
release/dev-to-main-20261004111450

Conversation

@SorraTheOrc

Copy link
Copy Markdown
Member

Automated release created by ship skill.\n\nIncludes CHANGELOG.md with work-item summaries from this release.

pi added 29 commits September 30, 2026 12:21
…ion)

The src/version.ts had WORKLOG_VERSION='1.0.16' while package.json
was at 1.0.17. This caused test failures in cli/init.test.ts where the
CLI reported 1.0.16 but tests expected 1.0.17.

Fix: regenerate via scripts/generate-version.cjs.

Discovered during test verification for WL-0MUIB7D30009KG00.
Delete src/openbrain.ts and all call sites (update.ts, close.ts).
Remove openBrainEnabled from WorklogConfig (types.ts).
Remove openBrainEnabled: true from .worklog/config.yaml.
Delete test files (openbrain.test.ts, openbrain-close.test.ts).
Delete docs (openbrain.md, openbrain-playwright-fallback-retrieval.md).
Remove references from CLI.md and README.md.
Update comment in cli.ts.

AC3 verified: repo-wide rg search for openbrain/submitToOpenBrain/openBrainEnabled returns no matches.
…CGV3X0030W6K)

Two fixes:

1. Parsing: The dash qualifier regex [^*:]+? was too permissive, matching
   any characters except * and :. This caused question text containing
   em dashes (e.g. "Crash behaviour — destroyed and respawn (like enemy)")
   to be incorrectly truncated at the em dash, with the text treated as a
   qualifier rather than question content. Fixed by excluding >, (, ) from
   the character class: [^*>:(]+?

2. Display: createPromptLoop used process.stdout.write() with embedded
   newlines in the message, which conflicted with readline terminal
   management. Switched to rl.question() which properly handles the
   prompt display without conflicts.

Added regression test for the em dash question text truncation.
Add a failing regression test that drives the full chord -> dispatch path for
w-r / w-s / w-b on podcast items (isChordLeader -> processChordInput ->
resolvePodcastTarget -> executeResolvedCommand), using the project-local
shortcuts.json shape (work_item_types gate included).

The test reproduces the reported failure shape: a plan_complete podcast item
with no script Key File and no open editor-note children. On unfixed code the
'w-s reports a MISSING-SCRIPT error (not "already present")' case fails:
resolvePodcastTarget returns the misleading 'podcast script already present'
message when no script exists. The remaining 8 tests pin the path that already
works (happy-path dispatch for w-r/w-s/w-b, stage-filter resolution,
non-podcast hiding, footer hints).

Refs OSL-0MUQ59IRF009ICIF.
Resolve the reported 'w-r / w-s / w-b do not fire on podcast items' defect
(OSL-0MUQ59IRF009ICIF).

Root cause (OSL-0MURL1S5O000Z0MH): the chords resolve correctly; the drop
happens in resolvePodcastTarget. On a script-less episode at a script-bearing
stage (plan_complete/in_review/done), w-s returned the false message
'podcast script already present, review and edit that rather than author a
new one'. The caller then showed a generic error toast and returned before
dispatch, so no agent pane opened.

Changes:
- resolvePodcastTarget: check for a missing .podcast.md script BEFORE the
  open-note-children check, so a script-less episode reports an accurate,
  actionable error naming the missing script and the next action.
- Footer hints: expand the type-gated podcast progression family so all three
  sub-options are advertised (w:write review...  w:write script...
  w:write both...) instead of the collapsed w:write.... Homogeneous ungated
  families (u/f/a/x/P/r/n) keep the collapsed form. Extracted as the pure,
  testable formatFooterShortcutHints helper.
- Tests: the regression tests from OSL-0MURL1T53003FP5W now pass; added
  coverage for the footer sub-option display (AC5) and a guard proving
  ungated chord families still collapse.

Verified: tsc -p packages/herdr clean; 3052 herdr vitest tests pass.

Refs OSL-0MUQ59IRF009ICIF.
@SorraTheOrc
SorraTheOrc merged commit c3ac6b0 into main Oct 4, 2026
1 of 2 checks passed
@SorraTheOrc
SorraTheOrc deleted the release/dev-to-main-20261004111450 branch October 4, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant