Repository navigation
Should fix issue 39 - #41
Merged
Merged
Conversation
…does not return the capturing groups, but the whole string if the match succeeds. The normalizing step was detecting the embedded double quotes and prepending ./ because `\""C:\...\""` is not a valid absolute path string. Tweaked the regex to nongreedy evaluation so it would properly stop before the ending doublequote of the current match instead of the last one in greedy mode.
…ary inner embedded doublequote stripping because the pattern tweaks mean the capture group will never contain an embedded doublequote anyways, and the specified path shouldn't have them either (unix allows, but why would you?). Added explicit prepending with -o after the path normalization step, which was missing, but was getting accidentally properly passed by the erroneous .match() full-string match before the normalizing step.
…ty() check. a `files: undefined` would not be deleted and the key would be attempted to process by the `for (const s in switches)` loop of the `Switches()` function, erroring out with "Cannot read properties of undefined (reading 'includes')" on line 203.
TheTechsTech
approved these changes
Oct 22, 2026
TheTechsTech
left a comment
TheTechsTech
left a comment
Owner
There was a problem hiding this comment.
Looks good, the whole CI build needs updating, too old.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the regex and algorithm for the runner arguments/switches preprocessing.
Fixes are tested to work on an installed package version with a couple test cases which should theoretically expand to the general case. Tried to build a repo version for testing but tsc started complaining about value and argument type mismatches that have nothing to do with the fix and I don't know where to begin with to start correcting.