bugfix(filesystem): Use native separators in archive listings

[bobtista]

• Depends on chore(pathutil): Add path separator helpers #3105 and bugfix(map): Handle map names without a path separator #3106, included until they merge
• Required by bugfix(map): Fix map cache paths on non-Windows #3107

Archive listings always append \, even when the directory already ends in /.

Now directory and filename paths use FileSystem::appendPathSeparator. The map scanner accepts either separator too, so it can read the resulting paths before #3107 merges.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 5001356c-06fd-409a-824c-f28067dc9e18

📥 Commits

Reviewing files that changed from the base of the PR and between bfa3bbf and 296c832.

📒 Files selected for processing (5)

• Core/GameEngine/Include/Common/FileSystem.h
• Core/GameEngine/Source/Common/System/ArchiveFile.cpp
• Core/GameEngine/Source/Common/System/FileSystem.cpp
• Core/GameEngine/Source/GameClient/MapUtil.cpp
• Core/Libraries/Include/Lib/PathUtil.h

Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review.

---

Walkthrough

The change adds shared path-separator and filename utilities. Filesystem path construction, directory checks, map discovery, and map display-name extraction use these utilities.

Changes

Path separator handling

Layer / File(s)	Summary
Path separator utilities Core/Libraries/Include/Lib/PathUtil.h	The utilities distinguish native separators from accepted separators. New helpers return the native separator, locate the last separator, and extract a filename. Both getExtension overloads use the last-separator helper.
Filesystem path construction Core/GameEngine/Include/Common/FileSystem.h, Core/GameEngine/Source/Common/System/FileSystem.cpp, Core/GameEngine/Source/Common/System/ArchiveFile.cpp	FileSystem adds native separator appending and uses the native separator in directory checks. Archive path construction uses the new append helper.
Map path handling Core/GameEngine/Source/GameClient/MapUtil.cpp	Map discovery and display-name extraction use the shared separator and filename helpers. Discovery retains its debug-crash-and-skip behavior when a path has no separator.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~15 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 296c8

The inspected path-handling changes preserve the relevant lookup and discovery behavior, with no actionable merge-blocking regression identified.

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: using native path separators in archive listings.
Description check	✅ Passed	The description directly explains the archive-listing separator bug and the related map-scanner updates.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

_{Comment @coderabbitai help to get the list of available commands.}