Skip to content

bugfix(map): Accept either path separator in map lookups - #3109

Draft
bobtista wants to merge 7 commits into
TheSuperHackers:mainfrom
bobtista:bobtista/bugfix/lan-map-resolution
Draft

bobtista wants to merge 7 commits into
TheSuperHackers:mainfrom
bobtista:bobtista/bugfix/lan-map-resolution

Conversation

@bobtista

@bobtista bobtista commented Aug 11, 2026 •

Copy link
Copy Markdown

Closes #3103
Depends on #3105

Map validation rejects a preferred map with different path separators and falls back to the default before LAN setup can resolve it.

Now validation uses findMap, and cache keys and lookups use native separators. LAN setup uses the resolved filename. Custom-match preferences also normalize separators for callers that still use exact lookups.

Reproduction:

  1. Select a non-default multiplayer map, then change its stored LAN preference to use the other separator or a mix of both.
  2. Host a LAN game.
  3. Check that the selected map is retained and the host has its availability, CRC, and size set.

Testing:

  • macOS integration probe: old validation selects the default for reversed and mixed separators; fixed validation retains the selected map and sets the expected host metadata.
  • Native separators, uppercase names, missing-map fallback, and custom-match preferences pass.
  • Separator helper passes sanitizer checks under both POSIX and Windows separator conventions.

@bobtista
bobtista marked this pull request as draft August 11, 2026 15:51
@bobtista bobtista self-assigned this Aug 11, 2026
@bobtista bobtista added the Platform Work towards platform support, such as Linux, MacOS label Aug 11, 2026
@bobtista
bobtista force-pushed the bobtista/bugfix/lan-map-resolution branch 2 times, most recently from 27877e2 to 5a83502 Compare August 28, 2026 07:18
@bobtista bobtista changed the title bugfix(gui): Resolve the host's selected map through the map cache bugfix(map): Resolve map names that carry either path separator Aug 28, 2026
@bobtista
bobtista force-pushed the bobtista/bugfix/lan-map-resolution branch from 5a83502 to 65f1e4c Compare September 11, 2026 17:32
@bobtista
bobtista force-pushed the bobtista/bugfix/lan-map-resolution branch from 65f1e4c to 4c4016b Compare September 14, 2026 21:06
@bobtista
bobtista force-pushed the bobtista/bugfix/lan-map-resolution branch from 4c4016b to 03ce108 Compare September 14, 2026 21:30
@bobtista bobtista changed the title bugfix(map): Resolve map names that carry either path separator bugfix(map): Accept either path separator in map lookups Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Platform Work towards platform support, such as Linux, MacOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Host's preferred LAN map is not matched when its stored name uses a different separator

1 participant