Repository navigation
Conversation
While it is later explained in on the same page, that one can edit the make file of the `flow` subdirectory to have the same effect, the command provided without the DESIGN_CONFIG flag will straight up not work at this point. Adding the flag will not harm here. Signed-off-by: René Kost <git@rkost.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the FlowTutorial.md documentation to include the DESIGN_CONFIG variable when running the make gui_final command. This ensures the correct design configuration is loaded when launching the OpenROAD GUI. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
DESIGN_CONFIGflag to themakecall in the tutorial. Omitting the flag at this point would lead to an error. While it is later explained (in the OpenROAD GUI section), that the same effect can be achieved by editing the flow Makefile, executing the command provided at this point of the tutorial will lead to an error.I think adding the flag here does no harm.