Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README explains how to modify mapped values with
iterator::value(), but that member is unavailable on the standard reverse-iterator adapter. Callingit.base().value()instead also refers to the wrong element and dereferencesend()atrbegin().Document
std::prev(it.base()).value()beside the existing forward-iteration example, including the required<iterator>header and the one-past position ofbase().Related to #43; this documents the existing API rather than adding a new reverse-iterator type.
Validation: compiled and ran the exact example with GCC 15.2 and Clang 21.1.8 under C++11, C++17 and C++20, with ASan/UBSan and strict warnings. Empty, single-element and multi-element maps pass with both deque and vector storage. The full Boost suite and other compilers were not run for this documentation-only change.