Repository navigation
fix(dashboard): Cashier Session Report shows real variance (#380) - #383
Merged
telivity-otaip merged 2 commits intoOct 15, 2026
Merged
Conversation
cashierReport returns countedBalance and variance on the report root, not under session. Read those fields with a session.* fallback so Variance no longer always shows $0.00. Fixes #380 Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
telivity-otaip
marked this pull request as ready for review
October 15, 2026 20:28
Cashier.test.tsx added 2 cases / 1 file; CI gate requires README and docs/test-stats.json to match (2476 / 287). Co-authored-by: telivity-otaip <telivity-otaip@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #380.
Problem: The Cashier Session Report bound
session.variance/session.countedBalance, butcashierReportreturns those fields on the report root. Variance always fell through to$0.00.Fix: Derive
countedBalanceandvariancefrom the report root, with a fallback tosession.*for older response shapes, keeping the—and0.00defaults.Test: Added
Cashier.test.tsxcovering the current API shape ($-47.50/$350.00) and the nested fallback.