Repository navigation
Align the test image name and bind the test proxy to loopback - #192
Open
Aaron-K-T-Berry wants to merge 1 commit into
Open
Aaron-K-T-Berry wants to merge 1 commit into
Aaron-K-T-Berry wants to merge 1 commit into
Conversation
- Clarified usage instructions for running the API proxy with the `--privileged` flag. - Updated testing instructions to specify the default image name as `docker-socket-proxy:local`. - Enhanced comments in the test setup to explain the necessity of the `--privileged` flag and the socket binding to `127.0.0.1`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--imagethe only way to select the test image, and default it todocker-socket-proxy:local.--prebuildbuilds that same tag, sopoetry run pytest --prebuildmatches CI and the README.127.0.0.1only, and fail the fixture if the inspected host address is anything else.--privilegedis requested so the container can open the Docker socket on hosts where SELinux or AppArmor confines it. Hosts that do not confine the socket do not need the flag.Test plan
poetry run pytest --prebuildbuildsdocker-socket-proxy:localand the suite passes.poetry run pytest --image definitely-missing:tag -k test_default_permissionsfails because that tag is the image pytest runs.DOCKER_IMAGE_NAMEdoes not change which image the suite runs.127.0.0.1:<port>, anddocker -H tcp://127.0.0.1:<port> versionreaches the engine.