You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: respect WiiCompiled mode when launching on startup - #535
Validation: all 24 startup and launcher tests passed on Windows. Linux/AppImage game startup was not tested.
Summary by CodeRabbit
Improvements
Startup now uses the active launcher to start Retro Rewind, aligning startup launch behavior with the Home page. Existing cancellation and failure handling remain in place, so interrupted launches and launch failures continue to be handled as before. No new user-facing settings or launch options are included in this update.
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.
📝 Walkthrough
Application startup now resolves the active launcher through ILauncherProvider and calls ILauncher.Launch(). Startup tests verify the new calls, including cases where shutdown prevents launching.
Changes: Startup launcher integration
Layer / File(s)
Summary
Resolve and launch the active launcher WheelWizard/Features/ApplicationLifecycle/ApplicationStartup.cs, WheelWizard.Test/Features/ApplicationLifecycle/ApplicationStartupTests.cs, WheelWizard/Features/Launching/LauncherProvider.cs
ApplicationStartup now uses ILauncherProvider to get the active launcher and calls Launch(). Tests verify the launch and shutdown behavior with the updated provider and launcher substitutes. The provider summary comment now includes startup as a consumer.
When WiiCompiled is enabled on a supported platform, startup routes through WiiCompiled rather than Dolphin. AppImage execution was not tested, but the source path is wired and no concrete merge-blocking issue was found.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 3 files.
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Title check
The title clearly and concisely describes the main change: applying WiiCompiled mode during startup launching.
Description check
The description explains the purpose, changed behavior, related issue, and test results. It does not use the template headings or include the checklist, but it provides the required information overal…
Linked Issues check
Issue [#484] requires startup Retro Rewind launch to use WiiCompiled when WiiCompiled is enabled. ApplicationStartup now calls ILauncherProvider.GetActiveLauncher().Launch() for saved startup laun…
Out of Scope Changes check
The changes stay within issue [#484]. They update startup launcher selection, update the related startup tests, and clarify the provider comment. No unrelated behavior is changed.
Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
Commit to this branch
Create a new PR
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks the launcher's door, The active path is clear once more. At startup, Launch() starts the run, While shutdown stops it, neat and done. Ears twitch; the tests confirm the score.
Comment @coderabbitai help to get the list of available commands.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Startup now uses the same launcher selection as Home, so enabling WiiCompiled also applies to automatic startup and
--launch rr.Fixes #484.
Validation: all 24 startup and launcher tests passed on Windows. Linux/AppImage game startup was not tested.
Summary by CodeRabbit