Skip to content

fix: respect WiiCompiled mode when launching on startup - #535

Open
DirkDoes wants to merge 1 commit into
mainfrom
fix/startup-respects-active-launcher
Open

DirkDoes wants to merge 1 commit into
mainfrom
fix/startup-respects-active-launcher

Conversation

@DirkDoes

@DirkDoes DirkDoes commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Startup now uses the same launcher selection as Home, so enabling WiiCompiled also applies to automatic startup and --launch rr.

Fixes #484.

Validation: all 24 startup and launcher tests passed on Windows. Linux/AppImage game startup was not tested.

Summary by CodeRabbit

  • Improvements
    • Startup now uses the active launcher to start Retro Rewind, aligning startup launch behavior with the Home page. Existing cancellation and failure handling remain in place, so interrupted launches and launch failures continue to be handled as before. No new user-facing settings or launch options are included in this update.

@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 63cece49-60dc-4541-ac48-111278e561df
📥 Commits

Reviewing files that changed from the base of the PR and between b270362 and a2a38a3.

📒 Files selected for processing: 3
  • WheelWizard.Test/Features/ApplicationLifecycle/ApplicationStartupTests.cs
  • WheelWizard/Features/ApplicationLifecycle/ApplicationStartup.cs
  • WheelWizard/Features/Launching/LauncherProvider.cs

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

📝 Walkthrough

Application startup now resolves the active launcher through ILauncherProvider and calls ILauncher.Launch(). Startup tests verify the new calls, including cases where shutdown prevents launching.

Changes: Startup launcher integration

Layer / File(s) Summary
Resolve and launch the active launcher
WheelWizard/Features/ApplicationLifecycle/ApplicationStartup.cs, WheelWizard.Test/Features/ApplicationLifecycle/ApplicationStartupTests.cs, WheelWizard/Features/Launching/LauncherProvider.cs
ApplicationStartup now uses ILauncherProvider to get the active launcher and calls Launch(). Tests verify the launch and shutdown behavior with the updated provider and launcher substitutes. The provider summary comment now includes startup as a consumer.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Medium

Suggested reviewers: patchzyy

Merge Risk: ⚪ Minimal · up to a2a38

When WiiCompiled is enabled on a supported platform, startup routes through WiiCompiled rather than Dolphin. AppImage execution was not tested, but the source path is wired and no concrete merge-blocking issue was found.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 3 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: applying WiiCompiled mode during startup launching.
Description check Passed The description explains the purpose, changed behavior, related issue, and test results. It does not use the template headings or include the checklist, but it provides the required information overal…
Linked Issues check Passed Issue [#484] requires startup Retro Rewind launch to use WiiCompiled when WiiCompiled is enabled. ApplicationStartup now calls ILauncherProvider.GetActiveLauncher().Launch() for saved startup laun…
Out of Scope Changes check Passed The changes stay within issue [#484]. They update startup launcher selection, update the related startup tests, and clarify the provider comment. No unrelated behavior is changed.
  • Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the launcher's door,
The active path is clear once more.
At startup, Launch() starts the run,
While shutdown stops it, neat and done.
Ears twitch; the tests confirm the score.

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Launch Retro Rewind on startup still opens Dolphin if Wiicompiled is on

1 participant