You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: correct cross-platform Debug build and test configuration - #534
Default solution Debug builds compile the application as Debug-Windows but tests as Debug. This selects WindowsUpdatePlatform even on Linux, while the updater registration test expects FallbackUpdatePlatform. Passing linux-x64 leaves both WINDOWS and LINUX defined in the app, where WINDOWS takes precedence.
How to Test:
Run dotnet test WheelWizard.sln. On Linux with .NET 10, also run dotnet test WheelWizard.sln -r linux-x64.
Verified on Windows with build-server reuse disabled and one MSBuild node: before the fix, 605 unit tests passed and the reported registration test failed; after the fix, all 606 unit tests and 65 UI tests passed. MSBuild evaluation confirms that linux-x64 now defines LINUX in both projects, without WINDOWS. Native Linux execution remains unverified because local Ubuntu only has .NET 8; this repository requires .NET 10.
What Has Been Changed:
Map the application's solution Debug configuration to Debug instead of Debug-Windows.
Match the application's runtime-dependent WINDOWS, LINUX, and MACOS symbols in the unit test project.
Without an explicit runtime, both projects use the fallback updater. Release mappings remain unchanged; official releases explicitly specify their runtime. Existing CI tests Release and misses this default Debug mismatch.
Related Issue Link:
No linked issue; implements the supplied patch for the reported Linux test failure.
Checklist before merging
You have created relevant tests
No new tests were added: the existing updater registration test reproduces the failure and passes with this fix.
Summary by CodeRabbit
Build & Compatibility
Build settings now align with Windows, Linux, and macOS targets, improving platform-specific build consistency.
Debug solution builds now use the standard Debug configuration across the solution.
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: ae6a01b4-adfc-4982-ac31-94f22ed905ad
📥 Commits
Reviewing files that changed from the base of the PR and between 14c0c7c and 1f4f85d.
📒 Files selected for processing: 2
WheelWizard.Test/WheelWizard.Test.csproj
WheelWizard.sln
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
📝 Walkthrough
The test project adds platform-specific compilation constants for listed runtime identifiers. The solution maps the WheelWizard Debug configuration to Debug instead of Debug-Windows.
The test project defines WINDOWS, LINUX, or MACOS based on RuntimeIdentifier. The solution maps the WheelWizard Debug configuration to Debug for both active configuration and build.
The default Debug configuration now aligns application and test fallback behavior, and no actionable merge-blocking issue was identified.
Pre-merge checks: 5
Passed checks: 5 passed
Check name
Status
Explanation
Title check
The title clearly and concisely describes the main change: correcting cross-platform Debug build and test configuration.
Description check
The description includes all template sections, explains the failure and fix, documents testing results and limitations, and states that no new tests were added.
Docstring Coverage
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks each build with care Three platform flags are waiting there Debug maps to Debug in line The settings match, the builds align I hop away; the configs shine
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR:
Default solution Debug builds compile the application as Debug-Windows but tests as Debug. This selects WindowsUpdatePlatform even on Linux, while the updater registration test expects FallbackUpdatePlatform. Passing linux-x64 leaves both WINDOWS and LINUX defined in the app, where WINDOWS takes precedence.
How to Test:
Run
dotnet test WheelWizard.sln. On Linux with .NET 10, also rundotnet test WheelWizard.sln -r linux-x64.Verified on Windows with build-server reuse disabled and one MSBuild node: before the fix, 605 unit tests passed and the reported registration test failed; after the fix, all 606 unit tests and 65 UI tests passed. MSBuild evaluation confirms that linux-x64 now defines LINUX in both projects, without WINDOWS. Native Linux execution remains unverified because local Ubuntu only has .NET 8; this repository requires .NET 10.
What Has Been Changed:
Without an explicit runtime, both projects use the fallback updater. Release mappings remain unchanged; official releases explicitly specify their runtime. Existing CI tests Release and misses this default Debug mismatch.
Related Issue Link:
No linked issue; implements the supplied patch for the reported Linux test failure.
Checklist before merging
No new tests were added: the existing updater registration test reproduces the failure and passes with this fix.
Summary by CodeRabbit