You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: Use Flatpak app ID for X11/Wayland window association if available - #531
Provide a fix for #469 (Wheel Wizard's taskbar icon not being displayed under Wayland when using the Flatpak).
How to Test:
Check out the latest Wayland-related PR in the Wheel Wizard Flathub repository, build and test the Flatpak under Wayland. The taskbar icon should be properly displayed with this change.
What Has Been Changed:
The Flatpak .desktop files' StartupWMClass values were updated to consistently use the Flatpak app ID (io.github.TeamWheelWizard.WheelWizard) rather than the default WheelWizard-internal assembly name WheelWizard.
The Avalonia packages were updated to 12.1.4, which allows specifying the Wayland AppId. We now override the default assembly name used in either WmClass or AppId if running as a Flatpak in both the X11 and Wayland platform options.
Improved Linux desktop integration by aligning the application’s window identity with its Flatpak app ID when running in Flatpak. This helps desktop environments correctly associate the app window with its launcher.
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
📝 Walkthrough
The desktop entries now use the Flatpak app ID as their startup window class. On Linux, the app applies FLATPAK_ID to X11 and Wayland options when available. Five Avalonia packages are updated from version 12.1.2 to 12.1.4.
Changes: Flatpak Window Identity
Layer / File(s)
Summary
Apply the Flatpak app ID Flatpak/*.desktop, WheelWizard/Program.cs
Both desktop entries set StartupWMClass to io.github.TeamWheelWizard.WheelWizard. The app reads FLATPAK_ID only in Flatpak and applies it to X11 and Wayland options when available. Otherwise, it retains the existing defaults.
The Flatpak window identity is consistent across the desktop entries and runtime configuration. No actionable merge-blocking risk is established.
Pre-merge checks: 5
Passed checks: 5 passed
Check name
Status
Explanation
Description check
The description includes all required sections. It explains the Wayland taskbar icon fix, testing steps, changed files and behavior, related issue #469, and the unchecked test checklist.
Title check
The title is concise and accurately describes the main change: using the Flatpak app ID for X11 and Wayland window association.
Docstring Coverage
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (3 skipped: 3 …
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
Commit to this branch
Create a new PR
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks the window name, Then sets the app ID just the same. The desktop entries match the view, Avalonia packages update too. One hop, one change, all neat and clear.
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR:
Provide a fix for #469 (Wheel Wizard's taskbar icon not being displayed under Wayland when using the Flatpak).
How to Test:
Check out the latest Wayland-related PR in the Wheel Wizard Flathub repository, build and test the Flatpak under Wayland. The taskbar icon should be properly displayed with this change.
What Has Been Changed:
The Flatpak
.desktopfiles'StartupWMClassvalues were updated to consistently use the Flatpak app ID (io.github.TeamWheelWizard.WheelWizard) rather than the default WheelWizard-internal assembly nameWheelWizard.The Avalonia packages were updated to
12.1.4, which allows specifying the WaylandAppId. We now override the default assembly name used in eitherWmClassorAppIdif running as a Flatpak in both the X11 and Wayland platform options.Related Issue Link:
#469
Checklist before merging
Summary by CodeRabbit