Fix startup build warnings and add filesystem regression tests

[DirkDoes]

Starting Wheel Wizard through a build reported 88 filesystem analyzer warnings and five xUnit assertion warnings. Route remaining filesystem calls through the existing filesystem abstraction, retain native path semantics in static helpers, and guard empty optional settings paths exposed by the mock filesystem.

Add four regression test files with 34 cases covering path traversal protection, patch filename normalization, cached setup filenames and supported Linux architectures, and mod archive compatibility. Update UI construction tests for the injected filesystem and use boolean assertions in settings recovery tests.

Validation on Windows:

• Full solution rebuild with --no-restore --no-incremental -warnaserror: zero warnings and errors.
• Both test projects: 620 tests passed (601 unit tests and 19 UI tests).
• Desktop startup smoke check: app remained running, no warning/error log entries, and empty stderr.
• git diff --check passed.

Linux and macOS native builds and startup have not been verified.

Summary by CodeRabbit

• Reliability
  • Improved consistency in how file and folder paths are handled across settings, mod management, installations, and launching.
  • Settings now avoid treating blank or quoted executable paths as valid files.
• Tests
  • Added coverage for safe path handling, mod archive compatibility, patch filenames, and platform-specific installer names.
  • Updated settings tests without changing their behavior.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 17710674-98e2-49ce-8475-eaa9ebd69129

---

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 8034b6e8-2374-4df7-85ec-72fa92b4a5b1

---

📥 Commits

Reviewing files that changed from the base of the PR and between 47d36a3 and 4ff6ca1.

---

📒 Files selected for processing (23)

• WheelWizard.Test/Features/Patches/LooseBrsarPatchFileNameTests.cs
• WheelWizard.Test/Features/Patches/ModPatchCompatibilityTests.cs
• WheelWizard.Test/Features/Recomp/RecompPlatformTests.cs
• WheelWizard.Test/Features/Settings/SettingsRecoveryTests.cs
• WheelWizard.Test/Shared/IO/PathSafetyTests.cs
• WheelWizard.UI.Test/ModBrowserPreviewTests.cs
• WheelWizard/Features/CustomDistributions/RetroRewindBeta.cs
• WheelWizard/Features/Launching/RetroRewindLaunchDescriptor.cs
• WheelWizard/Features/MiiRendering/Services/NativeMiiRenderer.cs
• WheelWizard/Features/Patches/LooseBrsarPatchFileName.cs
• WheelWizard/Features/Patches/ModPatchConversionService.cs
• WheelWizard/Features/Patches/SzsPatchConverter.cs
• WheelWizard/Features/Recomp/RecompInstallService.cs
• WheelWizard/Features/Recomp/RecompLinuxInstallService.cs
• WheelWizard/Features/Recomp/RecompPlatform.cs
• WheelWizard/Program.cs
• WheelWizard/Shared/IO/PathSafety.cs
• WheelWizard/Views/Pages/MiiListPage.axaml.cs
• WheelWizard/Views/Pages/Settings/OtherSettings.axaml.cs
• WheelWizard/Views/Pages/Settings/RecompSettings.axaml.cs
• WheelWizard/Views/Pages/Settings/WhWzSettings.axaml.cs
• WheelWizard/Views/Popups/ModManagement/ModContent.axaml.cs
• WheelWizard/Views/Storage/StoragePaths.cs

---

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

---

---

📝 Walkthrough

Walkthrough

The changes replace static path and filesystem calls with filesystem abstractions across application services and views. They add tests for path safety, archive compatibility, and Recomp platform filenames, and update UI tests to provide mock filesystems.

Changes

Filesystem Path Handling

Layer / File(s)	Summary
Path safety and archive conversion WheelWizard/Shared/IO/PathSafety.cs, WheelWizard/Features/Patches/*, WheelWizard.Test/Shared/IO/PathSafetyTests.cs, WheelWizard.Test/Features/Patches/*	Path safety and patch-conversion code use path abstraction APIs. Tests cover path validation, archive compatibility, and BRSAR filename normalization.
Runtime path operations WheelWizard/Features/CustomDistributions/RetroRewindBeta.cs, WheelWizard/Features/Launching/RetroRewindLaunchDescriptor.cs, WheelWizard/Features/MiiRendering/Services/NativeMiiRenderer.cs, WheelWizard/Features/Recomp/*, WheelWizard/Program.cs, WheelWizard/Views/Pages/MiiListPage.axaml.cs, WheelWizard/Views/Storage/StoragePaths.cs, WheelWizard.Test/Features/Recomp/RecompPlatformTests.cs	Runtime services use filesystem path operations for path normalization, filename and extension handling, and path comparison. Recomp platform tests cover cached setup names and Linux assets.
Settings filesystem checks WheelWizard/Views/Pages/Settings/*, WheelWizard.Test/Features/Settings/SettingsRecoveryTests.cs	Settings views receive filesystem dependencies for file and directory checks and path operations. Recovery tests use Assert.True and Assert.False for boolean conditions.
Mod download filesystem operations WheelWizard/Views/Popups/ModManagement/ModContent.axaml.cs, WheelWizard.UI.Test/ModBrowserPreviewTests.cs	ModContent uses its injected filesystem for download paths, temporary-folder operations, and URL filename extraction. UI tests pass a mock filesystem to its constructions.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Refactor

Suggested reviewers: patchzyy

---

Merge Risk | ⚪ Minimal · up to 4ff6c

Merge Risk: ⚪ Minimal · up to 4ff6c

No actionable issue remains from this review; the change is mergeable after normal checks.

Security Architecture Review

Security architecture risk: 🔵 Low · up to 4ff6c

The change preserves the inspected path checks and keeps production downloads and installation on the same filesystem implementation. No introduced security regression was established. Risk remains low rather than minimal because cross-platform behavior and some failure and concurrency guarantees remain unverified.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

• inferred — The inspected sensitive authority is local filesystem access exercised by the desktop process. Intended download and installation roots are application-level restrictions, not an operating-system sandbox; effective exposure also depends on process permissions and filesystem topology.

Security Findings and Attack Paths

• observed — Externally supplied URLs, response filenames and archive entry names reach local download or extraction operations. The inspected paths apply filename or relative-path validation before writes. This establishes the routed source-to-sink paths and their controls, not that arbitrary archive contents are trusted or that every extraction implementation is covered.

Trust Boundaries and Controls

• observed — PathSafety implements lexical normalization and containment. It rejects rooted inputs and parent-traversal segments, then checks the resolved candidate against the intended directory. Its inspected implementation does not resolve symbolic links or establish exclusive ownership of destination paths.

Hardening Proposals

• proposed — Consider documenting native-path compatibility as a filesystem-provider contract and validating it on supported platforms. For installation lifecycle hardening, consider durable ownership recording and operation-scoped temporary folders so interruption or concurrent work cannot undermine cleanup. These are proposals, not findings introduced by this PR.

---

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 5.48% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 73 functions across 23 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main changes: addressing build warnings and adding filesystem regression tests.
Description check	✅ Passed	The description explains the purpose, changes, testing steps, results, and platform limitations. It does not include a related issue link or the template checklist, but it is otherwise complete.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

✨ Finishing Touches 💡 2

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

---

🛠️ Fix failing CI checks 💡

• Commit to this branch
• Create a new PR

---

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

---

_{A rabbit checks each path with care,
Then hops through folders here and there.
The names line up, the tests run bright,
Mock files help the views take flight.
The downloads find their proper place,
And carrots follow at a pace.}

_{Comment @coderabbitai help to get the list of available commands.}