Skip to content

🔒 Fix unsafe PowerShell execution in notification standard library - #354

Closed
Tcode-Motion wants to merge 2 commits into
mainfrom
fix/powershell-notification-security-18421920614302179730
Closed

Tcode-Motion wants to merge 2 commits into
mainfrom
fix/powershell-notification-security-18421920614302179730

Conversation

@Tcode-Motion

Copy link
Copy Markdown
Owner

🎯 What: Hardened PowerShell execution in standard notification library (stdlib/src/notification.rs) by adding -NoProfile and -NonInteractive flags and refactoring argument construction into a cross-platform testable helper function.

⚠️ Risk: Executing PowerShell without -NoProfile and -NonInteractive flags allows execution of untrusted user profile scripts (Microsoft.PowerShell_profile.ps1) when launching powershell.exe, potentially allowing privilege escalation or arbitrary code execution via profile hijacking.

🛡️ Solution: Updated stdlib/src/notification.rs to include -NoProfile and -NonInteractive flags when spawning PowerShell, preventing user profile script execution and interactive stalls. Refactored argument construction into build_powershell_notification_args and added unit tests to verify security flags and safe encoding of arbitrary input strings.


PR created automatically by Jules for task 18421920614302179730 started by @Tcode-Motion

Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions
github-actions Bot marked this pull request as ready for review October 27, 2026 19:33
…stabilize thread example sleep timing

Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant